Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC beta] Mark comments as private #4010

Merged
merged 1 commit into from
Dec 17, 2015
Merged

[DOC beta] Mark comments as private #4010

merged 1 commit into from
Dec 17, 2015

Conversation

pangratz
Copy link
Member

Otherwise YUIDoc complains that those methods don't have an item type:

> ember build --environment=production
version: 1.13.12
Could not find watchman, falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.
Building
info: YUIDoc Starting from: /home/travis/build/emberjs/data/addon,/home/travis/build/emberjs/data/node_modules/ember-inflector
warn: Missing item type:  /home/travis/build/emberjs/data/addon/-private/system/model/internal-model.js:300
warn:       Checks if the attributes which are considered as changed are still
different to the state which is acknowledged by the server.
This method is needed when data for the internal model is pushed and the
pushed data might acknowledge dirty attributes as confirmed.
warn: Missing item type:  /home/travis/build/emberjs/data/addon/-private/system/model/internal-model.js:321
warn:       Returns an object, whose keys are changed properties, and value is an
[oldProp, newProp] array.
info: Making out dir: /home/travis/build/emberjs/data/tmp/broccoli_yuidoc-output_path-7S7rqKph.tmp/docs
info: Parsed 105 files in 0.085 seconds
info: Building..

Otherwise YUIDoc complains that those methods don't have an item type.
bmac added a commit that referenced this pull request Dec 17, 2015
[DOC beta] Mark comments as private
@bmac bmac merged commit e42d919 into emberjs:master Dec 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants