Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JSON-API adapter and serializer in blueprints #4019

Merged
merged 1 commit into from
Dec 21, 2015
Merged

Use JSON-API adapter and serializer in blueprints #4019

merged 1 commit into from
Dec 21, 2015

Conversation

pangratz
Copy link
Member

This addresses ember-cli/ember-cli#4787.

@bmac
Copy link
Member

bmac commented Dec 21, 2015

@pangratz do you mind amending this commit message to start with [BUGFIX beta]?

@pangratz
Copy link
Member Author

Sure thing.

@igorT
Copy link
Member

igorT commented Dec 21, 2015

Looks good. @pangratz if you have time, it would be awesome to do the thing where it uses applicationSerializer if there is one.

@igorT
Copy link
Member

igorT commented Dec 21, 2015

@bmac says they already do that, so nevermind me if they do

igorT added a commit that referenced this pull request Dec 21, 2015
Use JSON-API adapter and serializer in blueprints
@igorT igorT merged commit 24147f1 into emberjs:master Dec 21, 2015
@pangratz pangratz mentioned this pull request Dec 21, 2015
3 tasks
@pangratz
Copy link
Member Author

@bmac says they already do that, so nevermind me if they do

If I am reading the current blueprints correctly, this is not the case 😨. I've opened a followup PR #4023 which addresses this...

@pangratz pangratz deleted the use-json-api-in-blueprints branch December 21, 2015 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants