New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] don't load "app" code when loading globals files #4063

Merged

fivetanley merged 1 commit into emberjs:master from fivetanley:globals-fixes

Jan 12, 2016

Commits on Jan 12, 2016

[BUGFIX release] don't load "app" code when loading globals files

The code that gets compiled for the globals build is in a closure with
its own instance of `loader.js`, so the entries for ember-data don't end
up in ember-cli's instance of `loader.js`. The ember-data code does
include shims that end up in the app's instance of loader.js, so we
exclude the app code from running in this case.

Stanley Stuart committed Jan 12, 2016