Update blueprints to import modules directly #4070
Conversation
HeroicEric
changed the title
HeroicEric
force-pushed
the
use-modules-in-blueprints
branch
from
2e44a7b
to
2dfbdf6
Compare
|
FYI, I have an somewhat accompanying PR #4023 open, which would make your adapter test The failing tests should be fixed once a new release for This looks very good to me 👍 ! Nice change importing modules directly! |
- Import JSONAPIAdapter module directly in blueprint - Import JSONAPISerializer module directly in blueprint - Import Transform module directly in blueprint - Import attr module directly in model blueprints when needed - Import belongsTo and hasMany modules directly in blueprints when needed
HeroicEric
force-pushed
the
use-modules-in-blueprints
branch
from
2dfbdf6
to
bcab3b5
Compare
|
@pangratz turns out, the tests were failing because of a typo Would you like me to remove the |
|
No, you can leave it in I guess. This PR will likely be merged soon, so I will update the test in #4023 once this is the case. |
| } | ||
|
|
||
| if (shouldImportBelongsTo && shouldImportHasMany) { | ||
| importStatements.push('import { belongsTo, hasMany } from \'ember-data/relationships\';'); |
There was a problem hiding this comment.
Out of scope for this pr but I've been thinking it may be useful to add a path that allows users to import belongsTo, hasMany and attr all on the same line.
|
This should wait until #4075 is resolved |
|
^^ was fixed by #4091 |
Update blueprints to import modules directly
|
Thanks @HeroicEric |
TL;DR;
This does two things:
DSI originally added the extra tests to cover the existing behavior before I changed it. If you'd rather have those split out into a separate PR LMK.
Details
JSONAPIAdaptermodule directly in blueprintJSONAPISerializermodule directly in blueprintTransformmodule directly in blueprintattrmodule directly in model blueprints when neededbelongsToandhasManymodules directly in blueprints when needed