Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove unnecessary inline JSHint config #4084

Merged
merged 1 commit into from
Jan 15, 2016

Conversation

HeroicEric
Copy link
Sponsor Member

  • Ember is imported below so we don鈥檛 need the global 馃槃
  • The eqnull:true rule was originally added for
    beb2f26 but was later added to the .jshintrc in
    caa2753

@fivetanley
Copy link
Member

馃崟

@fivetanley
Copy link
Member

can you prefix the commit message with [cleanup], please?

- Ember is imported below so we don鈥檛 need the global 馃槃
- The `eqnull:true` rule was originally added for
emberjs@beb2f26
050fd7b but was later added to the `.jshintrc` in
emberjs@caa2753
3ed8fd7?diff=unified
@HeroicEric HeroicEric force-pushed the ek-remove-inline-jshint-config branch from abaf758 to 67c4bc8 Compare January 15, 2016 04:54
@HeroicEric HeroicEric changed the title Remove unnecessary inline JSHint config [cleanup] Remove unnecessary inline JSHint config Jan 15, 2016
@HeroicEric
Copy link
Sponsor Member Author

This should also fix the test failures in #4082 & #4081

bmac added a commit that referenced this pull request Jan 15, 2016
[cleanup] Remove unnecessary inline JSHint config
@bmac bmac merged commit b050b0f into emberjs:master Jan 15, 2016
@bmac
Copy link
Member

bmac commented Jan 15, 2016

Thanks @HeroicEric

@HeroicEric HeroicEric deleted the ek-remove-inline-jshint-config branch January 15, 2016 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants