-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import require #4135
import require #4135
Conversation
7db232d
to
6307f62
Compare
i believe you should be able to actually import require
does that still cause an issue? |
I tried that originally and travis tests failed so switched to the way it is now |
Is there a reason we can't just |
Originally when this code was added |
Just an idea since the |
The global require in this file was causing an error when using babel 6 with the transform-es2015-modules-amd plugin fixes emberjs#4134
6307f62
to
617f5a6
Compare
Thanks @jmurphyau. |
I don't know if this matters here, but it seems to me we should avoid using hasOwnProperty() because it is slow. Maybe here it's not a hot path, so I guess it's ok. |
Since this will be stripped in production builds I think this is ok... |
You're completely right |
The global require in this file causes an error when using babel 6 with the transform-es2015-modules-amd plugin
fixes #4134