Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document behavior of object level errors with JSON API #4141

Merged
merged 1 commit into from Feb 10, 2016
Merged

[DOC] Document behavior of object level errors with JSON API #4141

merged 1 commit into from Feb 10, 2016

Conversation

adam-knights
Copy link
Contributor

This documents behavior added in #3909.


The JSON API spec also allows for object level errors to be placed
in an object with pointer `data`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like travis didn't like this pr because of extra trailing whitespace on some of these blank lines. @adam-knights do you mind amending this commit and removing the whitespace?

@pangratz
Copy link
Member

pangratz commented Feb 9, 2016

Besides my tiny comments this looks good to me. Thank you very much @adam-knights!

@adam-knights
Copy link
Contributor Author

np, thanks @pangratz @bmac, those changes are now made.

pangratz added a commit that referenced this pull request Feb 10, 2016
[DOC] Document behavior of object level errors with JSON API
@pangratz pangratz merged commit be03d51 into emberjs:master Feb 10, 2016
@pangratz
Copy link
Member

Thanks @adam-knights!

@adam-knights adam-knights deleted the doc_ds_errors_base branch February 10, 2016 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants