Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key remapping for embedded belongsTo #4147

Merged
merged 1 commit into from
Feb 11, 2016

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented Feb 10, 2016

Closes #4068. This implements the same semantics for key that are used in JSONSerializer.

@bmac
Copy link
Member

bmac commented Feb 10, 2016

Does the same change need to happen in _serializeEmbeddedHasMany as well?

@bmac
Copy link
Member

bmac commented Feb 10, 2016

Also @ef4 do you mind amending the commit message to start with [BUGFIX beta]?

@grapho
Copy link

grapho commented Feb 10, 2016

@ef4 @bmac: I would think yes.. it needs to be included in _serializeEmbeddedHasMany as well... i primarily use embedded hasMany and that is the area in which i am having the issue.

@ef4
Copy link
Contributor Author

ef4 commented Feb 10, 2016

I fixed hasMany too, and amended the commit message.

Closes emberjs#4068. This implements the same semantics for `key` that are used in JSONSerializer, for both belongsTo and hasMany embedded records.
bmac added a commit that referenced this pull request Feb 11, 2016
Fix key remapping for embedded belongsTo
@bmac bmac merged commit 07264f0 into emberjs:master Feb 11, 2016
@bmac
Copy link
Member

bmac commented Feb 11, 2016

Thanks @ef4

@grapho
Copy link

grapho commented Feb 16, 2016

@bmac @ef4 thanks for the effort to fix this!

Quick question: since this thing is now merged.. that meant the fix will be available in the next release? or can i just reinstall my ember data and the fix will be there?

@fivetanley
Copy link
Member

@grapho This will be in the next release. Otherwise, you can pin to the commit in package.json if you are using ember-cli post Ember Data 2.3.0, or #canary in bower.json

@grapho
Copy link

grapho commented Feb 16, 2016

thanks @fivetanley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants