[CLEANUP] remove toString definitions for models in tests
#4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My string theory: the definitions for `toString` are a relict from the pre-container era where this might have been needed. 💈 This makes the recently failing builds for `master` green again. 🍏 --- Note: the tests were failing since `2.3.1` ember seals `Mixin` so adding stuff after `create` will error out.
bmac
added a commit
that referenced
this pull request
Feb 16, 2016
[CLEANUP] remove `toString` definitions for models in tests
|
Thanks @pangratz 🚥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My string theory: the definitions for
toStringare a relict from thepre-container era where this might have been needed. 💈
This makes the recently failing builds for
mastergreen again. 🍏Note: the tests were failing since
2.3.1ember sealsMixinso adding stuffafter
createwill error out: emberjs/ember.js#12612.