Strip code for DS_WARN_ON_UNKNOWN_KEYS warning in production #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wrap code inside runInDebug so it is stripped from production - update checks so they work correctly with passed payload, which is actually a JSON-API document
| } | ||
| runInDebug(() => { | ||
| // If Ember.ENV.DS_WARN_ON_UNKNOWN_KEYS is set to true and the payload | ||
| // contains unknown attributes or relationships, log a warning. |
There was a problem hiding this comment.
Fun fact: All the code inside runInDebug get striped but this comment is preserved.
|
Thanks @pangratz |
bmac
added a commit
that referenced
this pull request
Mar 9, 2016
Strip code for DS_WARN_ON_UNKNOWN_KEYS warning in production
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually a JSON-API document