Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ds-links-in-record-array] Add links to RecordArray when present on payload #4263

Merged
merged 1 commit into from Mar 29, 2016
Merged

[FEATURE ds-links-in-record-array] Add links to RecordArray when present on payload #4263

merged 1 commit into from Mar 29, 2016

Conversation

danmcclain
Copy link
Contributor

No description provided.

@bmac
Copy link
Member

bmac commented Mar 27, 2016

Looks good @danmcclain. Do you mind wrapping this change in a feature flag?

@danmcclain
Copy link
Contributor Author

@bmac will do, I had been parsing the urls into an object when working with them, would you like me to include that, or leave that for the end user?

@bmac
Copy link
Member

bmac commented Mar 27, 2016

Lets leave that to the end user for now.

@danmcclain danmcclain changed the title Add links to RecordArray when present on payload [FEATURE ds-links-in-record-array] Add links to RecordArray when present on payload Mar 28, 2016
@danmcclain
Copy link
Contributor Author

@bmac updated!

@danmcclain
Copy link
Contributor Author

And rebased!

@bmac bmac merged commit 768ae7a into emberjs:master Mar 29, 2016
@bmac
Copy link
Member

bmac commented Mar 29, 2016

Thanks @danmcclain

@danmcclain danmcclain deleted the add-links-to-record-array branch March 30, 2016 11:55
@jvanantwerp
Copy link

Does this only work for query() calls, or all of the find*() and calls as well? Also, is this the "document" level links section, or a links section associated with an individual resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants