New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ds-links-in-record-array] Add links to RecordArray when present on payload #4263

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
3 participants
@danmcclain
Contributor

danmcclain commented Mar 24, 2016

No description provided.

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Mar 27, 2016

Member

Looks good @danmcclain. Do you mind wrapping this change in a feature flag?

Member

bmac commented Mar 27, 2016

Looks good @danmcclain. Do you mind wrapping this change in a feature flag?

@danmcclain

This comment has been minimized.

Show comment
Hide comment
@danmcclain

danmcclain Mar 27, 2016

Contributor

@bmac will do, I had been parsing the urls into an object when working with them, would you like me to include that, or leave that for the end user?

Contributor

danmcclain commented Mar 27, 2016

@bmac will do, I had been parsing the urls into an object when working with them, would you like me to include that, or leave that for the end user?

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Mar 27, 2016

Member

Lets leave that to the end user for now.

Member

bmac commented Mar 27, 2016

Lets leave that to the end user for now.

@danmcclain danmcclain changed the title from Add links to RecordArray when present on payload to [FEATURE ds-links-in-record-array] Add links to RecordArray when present on payload Mar 28, 2016

@danmcclain

This comment has been minimized.

Show comment
Hide comment
@danmcclain

danmcclain Mar 28, 2016

Contributor

@bmac updated!

Contributor

danmcclain commented Mar 28, 2016

@bmac updated!

@danmcclain

This comment has been minimized.

Show comment
Hide comment
@danmcclain

danmcclain Mar 29, 2016

Contributor

And rebased!

Contributor

danmcclain commented Mar 29, 2016

And rebased!

@bmac bmac merged commit 768ae7a into emberjs:master Mar 29, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Mar 29, 2016

Member

Thanks @danmcclain

Member

bmac commented Mar 29, 2016

Thanks @danmcclain

@danmcclain danmcclain deleted the danmcclain:add-links-to-record-array branch Mar 30, 2016

@jvanantwerp

This comment has been minimized.

Show comment
Hide comment
@jvanantwerp

jvanantwerp Jun 14, 2016

Does this only work for query() calls, or all of the find*() and calls as well? Also, is this the "document" level links section, or a links section associated with an individual resource?

jvanantwerp commented Jun 14, 2016

Does this only work for query() calls, or all of the find*() and calls as well? Also, is this the "document" level links section, or a links section associated with an individual resource?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment