Transition an invalid created record to the deleted saved state when … #4293
Conversation
| assert.equal(get(record, 'currentState.stateName'), 'root.deleted.saved'); | ||
| assert.equal(get(store.peekAll('person'), 'length'), 0, 'The new person should be removed from the store'); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Just curious: any specific reason why this is not in tests/integration/records/delete-record-test.js?
|
|
||
| assert.equal(get(record, 'currentState.stateName'), 'root.deleted.saved'); | ||
| assert.equal(get(store.peekAll('person'), 'length'), 0, 'The new person should be removed from the store'); | ||
| }); |
There was a problem hiding this comment.
Can you add a test case for destroyRecord too? I think this fix should also work for #3688.
There was a problem hiding this comment.
Added a test case for destroyRecord.
|
Looks good 👍 Tiny nitpick: I would prefer using the adapter instead of |
…ed state when deleted. Closes emberjs#4289
|
@pangratz I've updated the test for this pr to not use the private |
|
Nice @bmac, feel free to merge once 🍏 |
…deleted.
Closes #4289