Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC beta] Overhaul documentation for reload / background reload #4338

Merged
merged 1 commit into from
Apr 29, 2016
Merged

[DOC beta] Overhaul documentation for reload / background reload #4338

merged 1 commit into from
Apr 29, 2016

Conversation

pangratz
Copy link
Member

@pangratz pangratz commented Apr 16, 2016

Initial stab at adding better documentation for the reload and background reload behavior of store.findRecord and store.findAll. The behavior has been described in the release blog post for v.13, but the API documentation currently lacks this information, which unfortunately caused some headaches (#4341, #4162, #4148, #3657, #3483).

@@ -981,6 +1047,85 @@ Store = Service.extend({
});
```

_When_ the returned promise resolves depends on the reload reload behavior,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo reload reload

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @xomaczar!

@bmac
Copy link
Member

bmac commented Apr 29, 2016

Looks great. Thanks @pangratz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants