Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors caused by merging an older pr #4392

Merged
merged 1 commit into from
May 23, 2016
Merged

Fix lint errors caused by merging an older pr #4392

merged 1 commit into from
May 23, 2016

Conversation

bmac
Copy link
Member

@bmac bmac commented May 23, 2016

No description provided.

@pangratz
Copy link
Member

Since this only affects a commit for a feature, should this be prefixed with [FEATURE ds-payload-hooks]?

Otherwise looks good to me, thanks @bmac!

@courajs
Copy link
Contributor

courajs commented May 23, 2016 •
edited
Loading

Ember core uses homu to prevent this sort of thing, right? Have y'all considered pulling her in?

@Turbo87 Turbo87 mentioned this pull request May 23, 2016
Merged
@bmac bmac merged commit 803b9ec into emberjs:master May 23, 2016
@bmac bmac deleted the fix-build branch May 23, 2016 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bmac @pangratz @courajs