Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] prevent record duplication due to EmbeddedRecordsMixin #4441

Closed
wants to merge 3 commits into from
Closed

[BUGFIX beta] prevent record duplication due to EmbeddedRecordsMixin #4441

wants to merge 3 commits into from

Commits on Jul 11, 2016

  1. [BUGFIX beta] prevent record duplication due to EmbeddedRecordsMixin,… 

    … proposed fix to emberjs#1829

When the EmbeddedRecordsMixin is used to persist embedded records to the backend, the parent record is handled
as expected. However, nested children are neglected in the run loop and upon pushing a returned payload from the server
into the store we end up with duplication. This commits adds a procedure for cleaning up these flagged 'uncommitted' records
from the store before pushing the created ones.
    @tarzan
    tarzan committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    5aeb181 View commit details
    Browse the repository at this point in the history

  2. add failing spec that shwos a hole in current implementation

    @tarzan
    tarzan committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    d44cc61 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2016

  1. fix the implementation

    @tarzan
    tarzan committed Jul 12, 2016
    Configuration menu
    Copy the full SHA
    33df55e View commit details
    Browse the repository at this point in the history