Cleanup record array manager #4591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
from
95ae791
to
cfe32d3
Compare
* add tests * remove unused feature of passing in an optional index to insert at
* leave note for future work, e.g. the cleanup that is happening should likely not happen.
* recordArray.invoke(‘createSnapshot’) was previously invoked on the result of `internal.getRecord()` which no longer has createSnapshot, but `invoke` doesn’t error if a method isn’t found. * recordArray.snapshot is private, we should underscore it * add tests
* ensure filter function updates just before destroy are ignored * add unit test coverage for what makes filtered-record-arrays different then RecordArray
* add unit tests * fixup shape
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
from
31a957a
to
81cf11c
Compare
igorT
reviewed
Oct 19, 2016
| query: null, | ||
| init() { | ||
| this._super(...arguments); | ||
| this.query = this.query || null; |
There was a problem hiding this comment.
Why the guard against existing on query and not on links
There was a problem hiding this comment.
this is due to links is state provided by internal loadRecords, and not via the constructor
| @@ -44,7 +48,7 @@ export default RecordArray.extend({ | |||
| loadRecords(records, payload) { | |||
| let token = heimdall.start('AdapterPopulatedRecordArray.loadRecords'); | |||
| //TODO Optimize | |||
| var internalModels = Ember.A(records).mapBy('_internalModel'); | |||
| let internalModels = records.map(record => get(record, '_internalModel')); | |||
There was a problem hiding this comment.
Ember.A()is heavy weight, for merely doing somethingmap+=>can do.
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
3 times, most recently
from
d2ddd72
to
fb3a66f
Compare
* move to integration (as it is tests interaction between store/manager/array) * remove unit tests already covered by tests/unit/record-arrays/record-arrays-test * cleanup file
stefanpenner
force-pushed
the
cleanup-record-array-manager
branch
from
fb3a66f
to
4b5fa40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.