dirty check to prevent liveRecordArrays being rebuilt too often #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmac test failure looks to just be a random appveyor crash, I don't think I'm allowed to restart it though. |
|
I think @igorT is the only one who can restart appveyor. When travis is green, I've been ignoring appveyor crashes due to network errors like that and merging with with a failing appveyor build if the pr doesn't make any changes to Ember Data's build. The appveyor check is mostly to make sure windows developers can contribute to Ember Data. So there is a very low risk of breaking the experience for windows devs if changes don't add new dependencies or change the build logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every call to
peekAllcurrently forces us to completely rebuild the live array. This is a stop gap until recordArrayManager can be improved ( @stefanpenner and I have been brainstorming our way through how to improve it.).