[PERF] flatten DS.Model to avoid multi-extend, expensive reopens, and extra mixin detection #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
changed the title
runspired
force-pushed
the
feat/flattened-ds-model
branch
from
2c594f2
to
61a962c
Compare
|
I'm skeptical of the benchmark numbers above, I think I may be getting trolled but haven't figured out where yet. However, I spent some time in the profiler and it's fairly clear that this change is a 40% win for the initial parse of DS.Model. Before After |
|
Obviously a secondary benefit of all this is a much cleaner flame chart for spotting where to optimize things in the future as well. |
igorT
reviewed
Dec 7, 2016
| } | ||
| }, | ||
|
|
||
| //Calculate the inverse, ignoring the cache |
There was a problem hiding this comment.
I think jscs usually complains about a lack of space
|
@runspired thanks for the annotated screenshot, it is very easy to now identify exactly what you saw :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4667 with a version that takes more commits so we preserve more of the history of where code came from.
Perf
We see some improvement in both the areas we expect (initial lookup, materialization), there may also be a modest 2-5% improvement in several other areas but I'm skeptical. I want to run more test runs on this, and I'd like @stefanpenner to put it in our app with me tomorrow and measure in the real world.
initial-modelFor-lookup
Master
{ "min": "1.75", "q1": "2.18", "q2": "2.40", "q3": "2.83", "max": "3.30", "avg": "2.48" }PR
{ "min": "1.80", "q1": "2.08", "q2": "2.14", "q3": "2.5", "max": "3.03", "avg": "2.33" }InternalModel.getRecord (238 total calls)
Master
{ "min": "6.84", "q1": "7.67", "q2": "9.36", "q3": "11.92", "max": "15.33", "avg": "9.94" }PR
{ "min": "6.60", "q1": "7.63", "q2": "8.17", "q3": "9.05", "max": "11.70", "avg": "8.49" }