Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPER WIP] Relationship State Overhaul #4726

Closed

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Dec 23, 2016

This is the beginnings of revisiting the objects / patterns used to manage the relationship layer in ember-data.

  • treat Relationship as an abstract base class
  • simpler BelongsToRelationship class
  • explicit ImplictRelationship class
  • simpler HasManyRelationship class

-- potential changes for this effort that may be bumped to a second PR after this one --

  • remove ManyArray (upgraded HasManyRelationship should be able to handle this entirely)
  • swap out ArrayProxy for a more custom solution.

Current HasMany Complexity
image_uploaded_from_ios_720

@BryanCrotaz
Copy link
Contributor

Is this part of Single Source of Truth?

@stefanpenner
Copy link
Member

@BryanCrotaz I believe this is just general relationship cleanup, preventing duplicate work and stuff.

@runspired
Copy link
Contributor Author

@BryanCrotaz @stefanpenner no, but it gets us closer to being able to implement it cleanly.

@runspired
Copy link
Contributor Author

A better version of this work is in #4882

@runspired runspired closed this Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants