[CLEANUP Beta] Linter changes for addon/-private (not -private/system) #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorT
reviewed
Jan 11, 2017
| @@ -401,7 +401,7 @@ export default Ember.Mixin.create({ | |||
| } | |||
|
|
|||
| // No path provided | |||
| var url = []; | |||
| const url = []; | |||
There was a problem hiding this comment.
Can we not use const for things that are not constants please
igorT
reviewed
Jan 11, 2017
| @@ -434,7 +434,7 @@ export default Ember.Mixin.create({ | |||
| @return {String} path | |||
| **/ | |||
| pathForType(modelName) { | |||
| var camelized = Ember.String.camelize(modelName); | |||
| const camelized = Ember.String.camelize(modelName); | |||
There was a problem hiding this comment.
yes, I am going back through these PRs per @bmac's suggestion:
"I believe Ember follows a convention of "liberally-let" per madhatted.com/2016/1/25/let-it-be and only allows const in module scope."
I'll update once the builds are working again.
pete-the-pete
force-pushed
the
linting-addon-private
branch
from
920b352
to
334125d
Compare
pete-the-pete
force-pushed
the
linting-addon-private
branch
from
334125d
to
bf21fb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor clean up for linter issues.