Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating gitignore to remove .idea #4767

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Updating gitignore to remove .idea #4767

merged 1 commit into from
Jan 30, 2017

Conversation

pete-the-pete
Copy link
Contributor

Wanted to add these so I don't accidentally commit them.

@jherdman
Copy link

Generally speaking one should add a global .gitignore for this sort of thing https://help.github.com/articles/ignoring-files/

@locks
Copy link
Contributor

locks commented Jan 25, 2017

I agree with @jherdman here. Ideally .idea wouldn't be in the gitignore either ;P

@pete-the-pete
Copy link
Contributor Author

Ah, makes sense. Should I remove .idea? or just close this?

@bmac
Copy link
Member

bmac commented Jan 30, 2017

@pete-the-pete lets remove .idea.

@pete-the-pete
Updating gitignore
7e2c45b 
Updating gitignore to remove idea
@pete-the-pete pete-the-pete changed the title Updating gitignore for VSCode Updating gitignore to remove .idea Jan 30, 2017
@bmac bmac merged commit 33457bc into emberjs:master Jan 30, 2017
@bmac
Copy link
Member

bmac commented Jan 30, 2017

Thanks @pete-the-pete.

@pete-the-pete pete-the-pete deleted the gitignore branch February 2, 2017 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pete-the-pete @jherdman @locks @bmac