misc cleanup #4813
Merged
misc cleanup #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Feb 22, 2017
•
stefanpenner
commented
- avoid needly internalModel -> type conversion, when the information is already present on the internalModel
- make asserts more consistent (ES6 interpolation etc)
- rename trueModelName to normalizedModelName
runspired
reviewed
Feb 22, 2017
addon/-private/system/store.js
Outdated
| @@ -746,7 +746,7 @@ Store = Service.extend({ | |||
|
|
|||
| let fetchedInternalModel = this._findEmptyInternalModel(internalModel, options); | |||
|
|
|||
| return promiseRecord(fetchedInternalModel, "DS: Store#findRecord " + internalModel.typeKey + " with id: " + get(internalModel, 'id')); | |||
| return promiseRecord(fetchedInternalModel, `DS: Store#findRecord ${internalModel.modeName} with id: ${internalModel.id}`); | |||
| let pendingFetchItem = { | ||
| internalModel, | ||
| resolver, | ||
| options | ||
| }; | ||
|
|
||
| let modelClass = internalModel.type; // TODO: is this needed? |
There was a problem hiding this comment.
no, this can be refactored to modelName. If so, this._pendingFetch should be refactored as well as we don't beed it to expecting modelClass
There was a problem hiding this comment.
Ya likely later PR, i think the review gods will be sad with the size of this one.
stefanpenner
force-pushed
the
cleanup
branch
2 times, most recently
from
77e4081
to
3aecffc
Compare
* avoid needly internalModel -> type conversion, when the information is already present on the internalModel * make asserts more consistent (ES6 interpolation etc) * rename trueModelName to normalizedModelName
stefanpenner
force-pushed
the
cleanup
branch
from
3aecffc
to
d94aef5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.