cleanup + reject with useful reasons #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
throw-useful-reason
branch
from
20d4190
to
77583a7
Compare
* es6 cleanup * promise cleanup * remove dangling promises / errors * throw useful error message when a payload does not include an expected record instead of `undefined`
stefanpenner
force-pushed
the
throw-useful-reason
branch
from
77583a7
to
1a752f4
Compare
stefanpenner
changed the title
|
Test failure is just on one of the appveyor things, and is unrelated to ember-data. |
stefanpenner
commented
Mar 3, 2017
|
|
||
| if (pair) { | ||
| pair.resolver.reject(error); | ||
| pair.resolver.reject(error || new Error(`Expected: '${internalModel}' to be present in the adapter provided payload, but it was not found.`)); |
There was a problem hiding this comment.
this is the only change to ember-data, previously undefined was throw, now it is an error with a actionable message.
|
Thanks @stefanpenner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefined