Stable has many promise proxy #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
stable-has-many-promise-proxy
branch
from
f60ea22
to
a1b0c41
Compare
1 task
sly7-7
reviewed
Mar 8, 2017
| } | ||
| this.__loadingPromise.set('promise', promise) | ||
| } else { | ||
| this.__loadingPromise = new PromiseManyArray({ |
There was a problem hiding this comment.
should we call PromiseManyArray.create() or new PromiseManyArray() ?
There was a problem hiding this comment.
Either should be fine
sly7-7
reviewed
Mar 8, 2017
tests/unit/promise-proxies-test.js
Outdated
| content.reload = () => Ember.RSVP.Promise.resolve(content); | ||
| let promise = Ember.RSVP.Promise.resolve(content); | ||
|
|
||
| let array = DS.PromiseManyArray.create({ |
bmac
reviewed
Mar 8, 2017
| this.__loadingPromise = null; | ||
| } | ||
|
|
||
| get _loadingPromise() { return this.__loadingPromise; } |
There was a problem hiding this comment.
Why have both _loadingPromise and __loadingPromise?
There was a problem hiding this comment.
Wanted to make sure it was readOnly without going through the update method. (So people don't accidentally bypass)
bmac
approved these changes
Mar 8, 2017
hjdivad
approved these changes
Mar 8, 2017
| const Person = DS.Model.extend({ | ||
| name: DS.attr('string'), | ||
| tag: DS.belongsTo('tag', { async: false }) | ||
| }); |
There was a problem hiding this comment.
Adding toStrings on these makes debugging a lot nicer.
There was a problem hiding this comment.
I can update all of them in a later PR
stefanpenner
force-pushed
the
stable-has-many-promise-proxy
branch
from
a1b0c41
to
bf7006d
Compare
stefanpenner
force-pushed
the
stable-has-many-promise-proxy
branch
from
bf7006d
to
6c601ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each's whicheachacross relationships.