New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate buildInternalModel, add _buildInternalModel. #4897

Merged

bmac merged 1 commit into emberjs:master from yethon:3250-privatize-buildInternalModel

Mar 28, 2017

Contributor

yethon commented Mar 27, 2017 •

edited

Loading

Prefixing the buildInternalModel private function with an underscore, based on this (slightly outdated) ticket 3250.

bmac approved these changes

View reviewed changes


          Deprecate buildInternalModel, add _buildInternalModel.

6972fd7

bmac force-pushed the 3250-privatize-buildInternalModel branch from 8dd5dd9 to 6972fd7 Compare

March 28, 2017 17:01

bmac merged commit f818378 into emberjs:master

Member

bmac commented Mar 28, 2017

Thanks @yethon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment