[BUGFIX] has-many relationship: set hasData when fetching link #5053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure what's wrong with Travis. |
stefanpenner
suggested changes
Jul 4, 2017
| assert.equal(get(records, 'length'), 0); | ||
| assert.equal(get(personsReference.value(), 'length'), 0); | ||
|
|
||
| done(); |
There was a problem hiding this comment.
lets not use done, instead use promises directly. That way when the promise rejects, the test fails.
| return Ember.RSVP.resolve({ data: [] }); | ||
| }; | ||
|
|
||
| var family; |
| }; | ||
|
|
||
| var family; | ||
| run(function() { |
| var personsReference = family.hasMany('persons'); | ||
| assert.equal(personsReference.remoteType(), "link"); | ||
|
|
||
| run(function() { |
| assert.equal(personsReference.remoteType(), "link"); | ||
|
|
||
| run(function() { | ||
| personsReference.load().then(function(records) { |
|
@csantero this looks reasonable, but we should double check. @igorT / @runspired / @hjdivad / @bmac r? |
|
@stefanpenner I've updated the test. |
hjdivad
approved these changes
Jul 11, 2017
|
Looks great, thanks for the contribution @csantero |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #4845. The problem is that
setHasDatawas only being called when at least one internal model was being added, which is not the case when the server returns an empty array.