[BUGFIX release] Preserve local relationship changes after persisting a delet… #5068
Conversation
|
I believe the test failure is related to this commit: 012372cd4 (I don't think either this PR or that commit are in in error, likely this PR needs some touch-ups, but I will review in more detail). |
|
I thought this too but setting the serializer to json-API for the added tests did not seem to fix at all. Could have been trolled. |
|
What remains is potentially a legitimate issue. Currently investigating. |
|
ah, i think i just implemented the fix wrong :P |
…ion when possible. This reverts commit 16b8a04. — The `deleteRecord() { return null; }` changes are to allow the back ported tests to work with the older JSONSerializer rather then the JSONAPISerializer which the test suite (in beta and master) use. For reference the JSONSerializer -> JSONAPISerializer landed -> emberjs#5003
| env.adapter.shouldBackgroundReloadRecord = () => false; | ||
| let _super = env.serializer.normalize; | ||
| env.serializer.normalize = function(klass, payload) { | ||
| // this is required, so that the backported test actually has meaning on the release branch |
There was a problem hiding this comment.
this was added to make the back-ported test make sense, without having to refactor a bunch of tests
| }); | ||
| env.adapter.shouldBackgroundReloadRecord = () => false; | ||
| env.adapter.deleteRecord = () => { | ||
| return null; |
There was a problem hiding this comment.
added to ease backport ^, was { data: null }
| }); | ||
| env.adapter.shouldBackgroundReloadRecord = () => false; | ||
| env.adapter.deleteRecord = () => { | ||
| return null; |
There was a problem hiding this comment.
added to ease backport ^, was { data: null }
| }); | ||
| env.adapter.shouldBackgroundReloadRecord = () => false; | ||
| env.adapter.deleteRecord = () => { | ||
| return null; |
There was a problem hiding this comment.
added to ease backport ^, was { data: null }
| }); | ||
| env.adapter.shouldBackgroundReloadRecord = () => false; | ||
| env.adapter.deleteRecord = () => { | ||
| return null; |
There was a problem hiding this comment.
added to ease backport ^, was { data: null }
| }); | ||
| env.adapter.shouldBackgroundReloadRecord = () => false; | ||
| env.adapter.deleteRecord = () => { | ||
| return null; |
There was a problem hiding this comment.
added to ease backport ^, was { data: null }
🚢
|
released as v2.14.5 🎉 |
…ion when possible.
This reverts commit 16b8a04.