[BUGFIX release] fix destroyRecord followed by unloadRecord and impli… #5077
Conversation
…cit inverse relationships
| let rel = this._implicitRelationships[key]; | ||
|
|
||
| let implicitRelationships = this._implicitRelationships; | ||
| this.__implicitRelationships = null; |
There was a problem hiding this comment.
This feels a little "insider baseball" to me but I don't have a better suggestion.
There was a problem hiding this comment.
@bmac well, we are in the same class were it is private... Ya It's not amazing. Other ideas end up being junky too. I may circle back after this gets backported, and try to tidy this pattern up.
There was a problem hiding this comment.
i think the basic approach is fine and i suspect it seems a bit iffy mainly because these data structures already have a lot of complicated state. I suspect landing the simplify relationships work will make this kind of resetting not look so bad
| let rel = this._implicitRelationships[key]; | ||
|
|
||
| let implicitRelationships = this._implicitRelationships; | ||
| this.__implicitRelationships = null; |
There was a problem hiding this comment.
i think the basic approach is fine and i suspect it seems a bit iffy mainly because these data structures already have a lot of complicated state. I suspect landing the simplify relationships work will make this kind of resetting not look so bad
…cit inverse relationships