{beta} Beta unload and create #5098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following should be possible: ```js const record = store.find(‘record’, 1); record.unloadRecord(); store.createRecord(‘record’, 1); ``` before this commit, the `createRecord` would fail, as the `record` would not yet be fully unloaded, and its ID would still be reserved.
|
This solves a longstanding problem, thank you! Anything I can do to help test this? |
|
@mileszim Sorry, i forgot to merge (and release). Thanks for the reminder
If you can double checked this solved your issue (in the beta branch), and report back. That would be great. |
|
@mileszim also, sorry this has been an issue for so long. :( :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.