Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] RecordReference returns null when not yet loaded #5217

Merged
merged 1 commit into from
Oct 10, 2017
Merged

[BUGFIX beta] RecordReference returns null when not yet loaded #5217

merged 1 commit into from
Oct 10, 2017

Conversation

xomaczar
Copy link
Contributor

Closes #5207

@xomaczar
Copy link
Contributor Author

cc @pangratz

pangratz
pangratz reviewed Oct 10, 2017
View reviewed changes
tests/integration/references/record-test.js
@@ -99,7 +99,7 @@ test("push(promise)", function(assert) {

test("value() returns null when not yet loaded", function(assert) {
var recordReference = env.store.getReference('person', 1);
assert.equal(recordReference.value(), null);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:trollface:

@pangratz pangratz merged commit 1fe7e46 into emberjs:master Oct 10, 2017
@pangratz
Copy link
Member

Thanks a bunch @xomaczar!!

@xomaczar xomaczar deleted the fix-5207 branch October 10, 2017 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pangratz pangratz pangratz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xomaczar @pangratz