[BUGFIX beta] Fix unloadAll to also unload live records #5350
Conversation
there's now an additional "updated" event when the record is unloaded during tear-down of the test suite
# Conflicts: # tests/integration/records/unload-test.js
| @@ -76,6 +76,13 @@ export default class RecordArrayManager { | |||
| this.internalModelDidChange(internalModel); | |||
| } | |||
|
|
|||
| recordWasUnloaded(internalModel) { | |||
| let array = this._liveRecordArrays[internalModel.modelName]; | |||
There was a problem hiding this comment.
@dwickern Since array isn't changing, maybe it's best to use const here?
There was a problem hiding this comment.
It was to match the existing code style
|
LGTM, bu @hjdivad could you review this please ? |
dwickern
changed the title
|
I will look into this issue and review this PR as part of #5378. I suspect the underlying issue is a combination of one we have already fixed with the issue seen in |
|
@runspired the test in this PR fails against your branch |
|
I dug in and while this fix appears to work it does not address an underlying issue:
|
|
The issue appears to be that records need to have been accessed to be unloaded correctly. |
|
I found the underlying issue and resolved it here: 55fd924 Thanks for the failing test and fix attempt, it was extremely helpful in narrowing in on the root cause. |
unloadAllshould also unload records which were fetched usingfindAll. Currently the unloaded records are destroyed but the record array isn't cleared. So callingfindAlla second time after unloading will return the destroyed records and fresh ones (potentially duplicates of the destroyed records).