Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Clarifying error message for polymorphic types #5518

Merged
merged 3 commits into from
Jul 10, 2018

Conversation

pete-the-pete
Copy link
Contributor

fix for #4633

@jmar910
Copy link
Contributor

jmar910 commented Jul 5, 2018

@pete-the-pete spent the afternoon working on this and realized you beat me to the punch. It looks like you need to update some more tests with the updated assertion. Feel free to use my work here jmar910@97d403f

@pete-the-pete
Copy link
Contributor Author

pete-the-pete commented Jul 5, 2018 via email

@jmar910
Copy link
Contributor

jmar910 commented Jul 5, 2018

no worries at all!

@runspired
Copy link
Contributor

Thanks so much @pete-the-pete @jmar910

@runspired runspired merged commit 5f8ff88 into emberjs:master Jul 10, 2018
NullVoxPopuli pushed a commit to NullVoxPopuli/data that referenced this pull request Sep 8, 2018
* [BUGFIX] Adding tests to assert exception when saving unloaded record

* Clarifying error message for polymorphic types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants