remove test waiter #5544
Merged
remove test waiter #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
suggested changes
Jul 26, 2018
| if (DEBUG) { | ||
| this.__asyncRequestCount = 0; | ||
|
|
||
| Ember.Test.registerWaiter(() => { |
There was a problem hiding this comment.
This requires a sibling Ember.Test.unregisterWaiter(fn) or it will leak
stefanpenner
suggested changes
Jul 26, 2018
| return ASYNC_REQUEST_COUNT === 0; | ||
| }); | ||
| } | ||
|
|
||
| export function guardDestroyedStore(promise, store, label) { | ||
| let wrapperPromise = resolve(promise, label).then(v => promise); | ||
|
|
There was a problem hiding this comment.
can we put the incrementer here? If so, that would likely bit-rot related tester waiter imbalances.
stefanpenner
approved these changes
Jul 26, 2018
bmac
pushed a commit
that referenced
this pull request
Jul 31, 2018
* remove test waiter * Add store encapsulated waiter * dont leak waiters * if debug add bugs * make calls symetrical (cherry picked from commit a5f1d41)
NullVoxPopuli
pushed a commit
to NullVoxPopuli/data
that referenced
this pull request
Sep 8, 2018
* remove test waiter * Add store encapsulated waiter * dont leak waiters * if debug add bugs * make calls symetrical
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test waiter is prone to pwn-ing folks with the current implementation. New implementation to follow.