Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX relationships] fix proxy isDestroying error #6234

Merged
merged 3 commits into from
Sep 20, 2019
Merged

[BUGFIX relationships] fix proxy isDestroying error #6234

merged 3 commits into from
Sep 20, 2019

Conversation

code0100fun
Copy link
Contributor

This fixes an error with async belongsTo relationships throwing an error like:

Cannot read property 'isDestroying' of null

This happens when the relationship fetch fails the first time and is then accessed again later.

Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't figure out looking at this why the jquery scenario would behave differently, you likely should try running that locally so you can poke at the failure

@runspired runspired merged commit e363d7f into emberjs:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants