Set group name to relationship.kind #6349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug in inspector where the groups are named the model name instead of the relationship type.
|
@rwwagner90 thanks for the fix? Any chance you could update a test to cover this please? We have some in https://github.com/emberjs/data/blob/master/packages/-ember-data/tests/integration/debug-adapter-test.js |
|
@igorT I just updated the existing tests to check the correct relationship types as the names for the groups. There seem to be other failures, but I don't know if they are related to my change or not. |
runspired
approved these changes
Aug 20, 2019
|
Thanks for merging! What release will this make it into? |
|
@rwwagner90 is this actively broken in the wild? We could backport as well and make sure it goes into beta |
|
@igorT yeah, inspector has been showing the wrong names for the groups for quite awhile. Not sure when exactly it started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in inspector where the groups are named the model name instead of the relationship type.