Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] generateIdForRecord tests for adapter encapsulation side quest #6824

Merged
merged 3 commits into from
Nov 30, 2019
Merged

[TEST] generateIdForRecord tests for adapter encapsulation side quest #6824

merged 3 commits into from
Nov 30, 2019

Conversation

Gaurav0
Copy link
Contributor

@Gaurav0 Gaurav0 commented Nov 29, 2019

For #6666

runspired
runspired approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@runspired runspired left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, a few tiny nits.

packages/unpublished-adapter-encapsulation-test-app/tests/integration/generate-id-test.js Outdated Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/generate-id-test.js Outdated Show resolved Hide resolved
packages/unpublished-adapter-encapsulation-test-app/tests/integration/generate-id-test.js Outdated Show resolved Hide resolved
@runspired runspired mentioned this pull request Nov 29, 2019
Closed
72 tasks
@runspired runspired added 🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166 🌲 📦 Encapsulation & Interface Tests 📦 🌲 labels Nov 29, 2019
@runspired runspired added this to In Development in Encapsulation & Interface Tests via automation Nov 29, 2019
@runspired runspired added this to In Development in 🌲 Project Trim 🌲 via automation Nov 29, 2019
@runspired runspired moved this from In Development to Ready To Ship in Encapsulation & Interface Tests Nov 29, 2019
@runspired runspired moved this from In Development to Ready To Ship in 🌲 Project Trim 🌲 Nov 29, 2019
@runspired runspired merged commit 2831d6b into emberjs:master Nov 30, 2019
Encapsulation & Interface Tests automation moved this from Ready To Ship to Completed Nov 30, 2019
🌲 Project Trim 🌲 automation moved this from Ready To Ship to Completed Nov 30, 2019
@Gaurav0 Gaurav0 deleted the generate_id_tests branch November 30, 2019 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ test This PR primarily adds tests for a feature 🌲 Project Trim 🌲 PRs related to https://github.com/emberjs/data/issues/6166
Projects
No open projects
Encapsulation & Interface Tests
  
Completed
🌲 Project Trim 🌲
  
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gaurav0 @runspired