[CHORE] Cron job to check for external deprecations #6844
Conversation
Gaurav0
force-pushed
the
move_assert_all_deprecations
branch
from
23b6a61
to
57c20e3
Compare
Gaurav0
changed the title
Gaurav0
force-pushed
the
move_assert_all_deprecations
branch
3 times, most recently
from
bd8c199
to
ee5a8f4
Compare
Gaurav0
force-pushed
the
move_assert_all_deprecations
branch
from
ee5a8f4
to
2b2f164
Compare
packages/unpublished-test-infra/addon-test-support/assert-all-deprecations.js
Outdated
Show resolved
Hide resolved
packages/unpublished-test-infra/addon-test-support/assert-all-deprecations.js
Outdated
Show resolved
Hide resolved
packages/unpublished-test-infra/addon-test-support/assert-all-deprecations.js
Outdated
Show resolved
Hide resolved
| env: | ||
| CI: true | ||
| ASSERT_ALL_DEPRECATIONS: true | ||
| run: yarn test |
There was a problem hiding this comment.
we should run
- basic tests
- fastboot tests
- fetch tests
- encapsulation tests
- canary/beta Ember tests
There was a problem hiding this comment.
In a future PR we should also consider how to monitor for deprecations in the relationship-performance-test-app, but that can be ignored for now.
There was a problem hiding this comment.
I didn't set up fastboot tests and they aren't working right now, so not adding them currently. What are the fetch tests?
Added the others.
There was a problem hiding this comment.
@Gaurav0 can you clarify what you mean by:
I didn't set up fastboot tests and they aren't working right now
I am happy to merge this and add fastboot and fetch tests in follow up
There was a problem hiding this comment.
Yes, I reverted updating test-helper.js in fastboot-test-app to assert on deprecations. I think the code I wrote with the custom QUnitAdapter for testem doesn't work in fastboot, that may be why it fails.
Co-Authored-By: Chris Thoburn <runspired@users.noreply.github.com>
For #6687