New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEPRECATION] deprecate intimate Reference.internalModel #6889

Merged

runspired merged 6 commits into emberjs:master from Gaurav0:deprecate_reference_internal_model

Apr 22, 2020

Contributor

Gaurav0 commented Dec 12, 2019 •

edited

Loading

@runspired I was able to refactor record-reference.ts to use public api but stuck on the rest here.

Gaurav0 force-pushed the deprecate_reference_internal_model branch 3 times, most recently from 1840ad4 to 2588555 Compare

December 12, 2019 20:49

runspired reviewed

View reviewed changes

packages/private-build-infra/addon/current-deprecations.ts Outdated Show resolved Hide resolved

runspired reviewed

View reviewed changes

packages/store/addon/-private/system/references/reference.ts Outdated Show resolved Hide resolved

runspired reviewed

View reviewed changes

packages/store/addon/-private/system/references/reference.ts Outdated Show resolved Hide resolved

runspired reviewed

View reviewed changes

packages/store/addon/-private/system/references/record.ts Outdated Show resolved Hide resolved

runspired reviewed

View reviewed changes

packages/store/addon/-private/system/references/record.ts Show resolved Hide resolved

runspired reviewed

View reviewed changes

packages/store/addon/-private/system/references/record.ts Show resolved Hide resolved

runspired reviewed

View reviewed changes

packages/store/addon/-private/ts-interfaces/record-data.ts Outdated Show resolved Hide resolved

runspired requested changes

View reviewed changes

Contributor

runspired left a comment

Overall this is looking great, I've left some comments for cleanup.

Gaurav0 and others added 6 commits

April 11, 2020 13:24


          [DEPRECATION] Deprecate intimate reference.internalModel

5d2545e


          Update record-refernce to use public store apis

505ac31


          svelte


          Update packages/private-build-infra/addon/current-deprecations.ts

596dc01


          Update packages/store/addon/-private/system/references/reference.ts

db10e73


          rewrite with feedback

157eaff

Gaurav0 force-pushed the deprecate_reference_internal_model branch from 72f85d3 to 157eaff Compare

April 11, 2020 22:06

runspired approved these changes

View reviewed changes

runspired merged commit 62b572c into emberjs:master

Gaurav0 deleted the deprecate_reference_internal_model branch

April 24, 2020 03:11

snewcomer added the 🌲 Project Trim 🌲 label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment