Notify that a default adapter type has been selected #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This commit has issues even with RC1. I'm not sure exactly what's going on. |
|
Seems like a good idea, can we get this passing? |
|
I'll take a look today |
This will notify that in the absence of custom adapter a default has been selected.
|
Unrelated tests were directly setting a store's adapter. Switched to |
|
@stefanpenner I think this is good to merge |
stefanpenner
added a commit
that referenced
this pull request
Apr 19, 2013
Notify that a default adapter type has been selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will notify that in the absence of custom adapter a default has been selected.
NOTE: This PR assume latest Ember with Ember.debug available, so maybe don't accept yet.