Optimize visiting the relating records #7096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btecu
reviewed
Mar 13, 2020
|
@pieter-v I'm a bit less certain about this change without also adding a perf test. Will likely also want to look at it running manually. |
|
@pieter-v Thanks so much for this deep dive! @runspired it seems like we landed more perf tests, is there anything blocking this? |
|
@igorT all we need to do is rebase so that the new performance test is run so that we can see the output from this change, I am otherwise 👍 on merging this. |
|
@runspired @igorT rebase done |
|
Performance check indicates a ~6500ms improvement for the unloading scenario, with other scenarios unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visiting all related records during
_cleanupOrphanedRecordDatasallocates and copies a large amount of unnecessary data. Using anIterablethis allocation is not done anymore.In one of our applications we have a large dataset with complex relations. Destroying a large number of records timed out after 10 minutes, with this fix it still takes two minutes (but it is already a big improvement)