Add date shim to fix cross browser issues with parsing ISO-8601 dates #723
Conversation
|
@klaaspieter It seems like we shouldn't modify the |
|
@wagenet updated the PR to use Ember.Date.parse in stead of Date.parse. It will only extend the prototype if I also removed two tests that weren't strict ES5 compliant. Any thoughts on how lenient we should be when parsing dates? |
|
@wagenet @klaaspieter Any updates on this? The current incorrect timezone handling is a real pain. |
| // before falling back to any implementation-specific date parsing, so that’s what we do, even if native | ||
| // implementations could be faster | ||
| // 1 YYYY 2 MM 3 DD 4 HH 5 mm 6 ss 7 msec 8 Z 9 ± 10 tzHH 11 tzmm | ||
| if ((struct = /^(\d{4}|[+\-]\d{6})(?:-(\d{2})(?:-(\d{2}))?)?(?:T(\d{2}):(\d{2})(?::(\d{2})(?:\.(\d{3}))?)?(?:(Z)|([+\-])(\d{2})(?::(\d{2}))?)?)?$/.exec(date))) { |
There was a problem hiding this comment.
might be nice to extract this regex as a closed over "constant"
|
Time parsing is a bitch, this will bring some extra sanity into the mix. I for one think this is good. @wagenet since you had the initial concerns i'll defer to you, but if u think its good lets pull it in. |
|
@wagenet I believe this is waiting on your feedback. Would be much appreciated if you could take a look and facilitate getting this merged. |
Add date shim to fix cross browser issues with parsing ISO-8601 dates
|
Thanks @tomdale! ❤️ |
It turns out that my fix for #538 doesn't correctly handle timezones in dates. This fixes that behavior by overriding Date.parse with a custom implementation taken from: https://github.com/csnover/js-iso8601