Failing test: 'When a record is loaded a second time, isLoaded should stay true #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely seems like something worth fixing. |
|
Pushed a potential fix, all tests pass, but I'm not sure if maybe I'm stepping on some intended behavior here? |
tomdale
added a commit
that referenced
this pull request
Apr 10, 2013
Failing test: 'When a record is loaded a second time, isLoaded should stay true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a record is loaded a second time after it has already been loaded (i.e. updating data), isLoaded briefly flips to false.
This can cause unexpected behavior in applications that observe isLoaded to prevent/defer expensive renders.