Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: activate all feature flags related to custom model classes #7510

Merged
merged 9 commits into from
May 11, 2021

Conversation

runspired
Copy link
Contributor

Activates all Features for 3.28

@runspired runspired requested a review from igorT May 7, 2021 08:58
@runspired runspired added the 🏷️ feat This PR introduces a new feature label May 7, 2021
@runspired runspired changed the title feat: activate all ffs related to CUSTOM_MODEL_CLASS feat: activate all feature flags related to custom model classes May 7, 2021
@github-actions
Copy link

github-actions bot commented May 7, 2021

Asset Size Report for 8f061f1

IE11 Builds

🛑 The size of the library EmberData has increased by +8.44 KB (+1.63 KB compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +6.94 KB.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +232.0 B.
⚠️ The uncompressed size of the package @ember-data/model has increased by +1.3 KB.

Changeset


EmberData +190.48 KB +8.44 KB (+39.31 KB +1.63 KB compressed)
    @ember-data/store +84.9 KB +6.94 KB (+17.52 KB +1.34 KB compressed)
        @ember-data/store/-private +83.99 KB +6.94 KB (+17.33 KB +1.34 KB compressed)
    @ember-data/record-data +25.18 KB +232.0 B (+5.2 KB +44.86 B compressed)
        @ember-data/record-data/-private +25.18 KB +232.0 B (+5.2 KB +44.86 B compressed)
    @ember-data/serializer +20.82 KB -24.0 B (+4.3 KB -4.64 B compressed)
        @ember-data/serializer/json-api +3.92 KB -24.0 B (+829.45 B -4.64 B compressed)
    @ember-data/model +20.76 KB +1.3 KB (+4.28 KB +256.81 B compressed)
        @ember-data/model/-private +20.28 KB +1.3 KB (+4.19 KB +256.81 B compressed)

Full Asset Analysis (IE11)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '190.48 KB' │
│ compressed │ '39.31 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '84.90 KB' │
│  compressed  │ '17.52 KB' │
│ % Of Library │   '44.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 83.99 KB  | 17.33 KB   | 98.9          | 44.1
	@ember-data/store/index                           | 936.00 B  | 193.17 B   | 1.1           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '25.18 KB' │
│  compressed  │ '5.20 KB'  │
│ % Of Library │   '13.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 25.18 KB  | 5.20 KB    | 100.0         | 13.2

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.82 KB' │
│  compressed  │ '4.30 KB'  │
│ % Of Library │   '10.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.75 KB   | 1.60 KB    | 37.2          | 4.1
	@ember-data/serializer/-private                   | 5.69 KB   | 1.17 KB    | 27.3          | 3.0
	@ember-data/serializer/json-api                   | 3.92 KB   | 829.45 B   | 18.9          | 2.1
	@ember-data/serializer/rest                       | 3.00 KB   | 633.18 B   | 14.4          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 53.24 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 44.37 B    | 1.0           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.76 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '10.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 20.28 KB  | 4.19 KB    | 97.7          | 10.6
	@ember-data/model/index                           | 486.00 B  | 100.30 B   | 2.3           | 0.2

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.47 KB' │
│  compressed  │ '3.81 KB'  │
│ % Of Library │   '9.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 9.31 KB   | 1.92 KB    | 50.4          | 4.9
	@ember-data/adapter/-private                      | 3.80 KB   | 804.07 B   | 20.6          | 2.0
	@ember-data/adapter/error                         | 1.95 KB   | 411.52 B   | 10.5          | 1.0
	@ember-data/adapter/index                         | 1.81 KB   | 381.80 B   | 9.8           | 0.9
	@ember-data/adapter/json-api                      | 1.60 KB   | 338.88 B   | 8.7           | 0.8

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '1.91 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 490.98 B   | 25.1          | 1.2
	ember-data/-private                               | 1.98 KB   | 418.75 B   | 21.4          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 251.16 B   | 12.9          | 0.6
	ember-data/setup-container                        | 503.00 B  | 103.81 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 65.62 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 56.54 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 51.80 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 50.56 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 50.15 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 50.15 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 49.73 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 48.91 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 47.88 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 46.64 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 45.81 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 45.81 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 44.99 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 33.43 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.15 KB' │
│  compressed  │ '1.68 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.11 KB   | 657.12 B   | 38.1          | 1.6
	ember-inflector/lib/helpers/pluralize             | 1.62 KB   | 342.18 B   | 19.9          | 0.9
	ember-inflector/lib/system/inflections            | 1.59 KB   | 335.78 B   | 19.5          | 0.8
	ember-inflector/index                             | 473.00 B  | 97.61 B    | 5.7           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 97.20 B    | 5.6           | 0.2
	ember-inflector/lib/system/string                 | 332.00 B  | 68.51 B    | 4.0           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 63.56 B    | 3.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 61.08 B    | 3.5           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.96 KB'  │
│  compressed  │ '625.54 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.47 KB   | 522.34 B   | 83.5          | 1.3
	@ember-data/debug/setup                           | 500.00 B  | 103.19 B   | 16.5          | 0.3

Modern Builds

🛑 The size of the library EmberData has increased by +7.84 KB (+1.57 KB compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +6.37 KB.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +232.0 B.
⚠️ The uncompressed size of the package @ember-data/model has increased by +1.27 KB.

Changeset


EmberData +170.81 KB +7.84 KB (+37.32 KB +1.57 KB compressed)
    @ember-data/store +75.22 KB +6.37 KB (+16.44 KB +1.27 KB compressed)
        @ember-data/store/-private +74.31 KB +6.37 KB (+16.24 KB +1.27 KB compressed)
    @ember-data/record-data +23.23 KB +232.0 B (+5.08 KB +46.31 B compressed)
        @ember-data/record-data/-private +23.23 KB +232.0 B (+5.08 KB +46.31 B compressed)
    @ember-data/serializer +19.34 KB -24.0 B (+4.23 KB -4.79 B compressed)
        @ember-data/serializer/json-api +3.69 KB -24.0 B (+826.41 B -4.79 B compressed)
    @ember-data/model +18.39 KB +1.27 KB (+4.02 KB +260.28 B compressed)
        @ember-data/model/-private +17.92 KB +1.27 KB (+3.92 KB +260.28 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '170.81 KB' │
│ compressed │ '37.32 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '75.22 KB' │
│  compressed  │ '16.44 KB' │
│ % Of Library │   '44.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 74.31 KB  | 16.24 KB   | 98.8          | 43.5
	@ember-data/store/index                           | 936.00 B  | 204.52 B   | 1.2           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.23 KB' │
│  compressed  │ '5.08 KB'  │
│ % Of Library │   '13.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.23 KB  | 5.08 KB    | 100.0         | 13.6

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.34 KB' │
│  compressed  │ '4.23 KB'  │
│ % Of Library │   '11.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.12 KB   | 1.56 KB    | 36.8          | 4.2
	@ember-data/serializer/-private                   | 5.37 KB   | 1.17 KB    | 27.8          | 3.1
	@ember-data/serializer/json-api                   | 3.69 KB   | 826.41 B   | 19.1          | 2.2
	@ember-data/serializer/rest                       | 2.71 KB   | 607.02 B   | 14.0          | 1.6
	@ember-data/serializer/index                      | 243.00 B  | 53.09 B    | 1.2           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.98 B    | 1.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.39 KB' │
│  compressed  │ '4.02 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 17.92 KB  | 3.92 KB    | 97.4          | 10.5
	@ember-data/model/index                           | 486.00 B  | 106.19 B   | 2.6           | 0.3

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '16.02 KB' │
│  compressed  │ '3.50 KB'  │
│ % Of Library │   '9.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 8.37 KB   | 1.83 KB    | 52.2          | 4.9
	@ember-data/adapter/-private                      | 3.58 KB   | 801.94 B   | 22.4          | 2.1
	@ember-data/adapter/error                         | 1.91 KB   | 428.06 B   | 11.9          | 1.1
	@ember-data/adapter/index                         | 1.14 KB   | 254.34 B   | 7.1           | 0.7
	@ember-data/adapter/json-api                      | 1.02 KB   | 227.90 B   | 6.4           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.24 KB' │
│  compressed  │ '2.02 KB' │
│ % Of Library │   '5.4'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 519.83 B   | 25.1          | 1.4
	ember-data/-private                               | 1.98 KB   | 443.36 B   | 21.4          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 265.92 B   | 12.9          | 0.7
	ember-data/setup-container                        | 503.00 B  | 109.91 B   | 5.3           | 0.3
	ember-data/relationships                          | 318.00 B  | 69.48 B    | 3.4           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 59.87 B    | 2.9           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 54.84 B    | 2.7           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 53.53 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 53.09 B    | 2.6           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 53.09 B    | 2.6           | 0.1
	ember-data/transform                              | 241.00 B  | 52.66 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 51.78 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 50.69 B    | 2.5           | 0.1
	ember-data/adapter                                | 226.00 B  | 49.38 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 48.50 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 48.50 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 47.63 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 35.39 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.45 KB' │
│ % Of Library │   '3.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 644.39 B   | 43.3          | 1.7
	ember-inflector/lib/system/inflections            | 1.59 KB   | 355.51 B   | 23.9          | 0.9
	ember-inflector/index                             | 473.00 B  | 103.35 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 102.91 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 81.50 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 69.48 B    | 4.7           | 0.2
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 67.30 B    | 4.5           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 64.67 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '604.18 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 495.14 B   | 82.0          | 1.3
	@ember-data/debug/setup                           | 499.00 B  | 109.03 B   | 18.0          | 0.3

Modern Builds (No Rollup)

🛑 The size of the library EmberData has increased by +1.47 KB (+243.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/record-data has increased by +230.0 B.
⚠️ The uncompressed size of the package @ember-data/model has increased by +1.29 KB.

Changeset


EmberData +210.37 KB +1.47 KB (+40.67 KB +243.0 B compressed)
    @ember-data/store +99.56 KB -24.0 B (+19.25 KB -3.88 B compressed)
        @ember-data/store/-private/system/core-store +17.14 KB +88.0 B (+3.31 KB +14.21 B compressed)
        @ember-data/store/-private/system/model/internal-model +16.24 KB -338.0 B (+3.14 KB -54.57 B compressed)
        @ember-data/store/-private/system/model/states +5.42 KB -46.0 B (+1.05 KB -7.43 B compressed)
        @ember-data/store/-private/system/fetch-manager +5.0 KB +32.0 B (+989.36 B +5.17 B compressed)
        @ember-data/store/-private/system/record-array-manager +4.11 KB -364.0 B (+813.64 B -58.77 B compressed)
        @ember-data/store/-private/system/store/record-data-store-wrapper +3.36 KB +167.0 B (+664.79 B +26.96 B compressed)
        @ember-data/store/-private/system/snapshot +3.21 KB +215.0 B (+634.64 B +34.71 B compressed)
        @ember-data/store/-private/system/ds-model-store +2.0 KB +13.0 B (+396.48 B +2.1 B compressed)
        @ember-data/store/-private/system/model/shim-model-class +1.32 KB +49.0 B (+260.77 B +7.91 B compressed)
        @ember-data/store/-private/system/model/notify-changes +1.04 KB +152.0 B (+205.29 B +24.54 B compressed)
        @ember-data/store/-private/system/record-notification-manager +697.0 B +8.0 B (+134.73 B +1.29 B compressed)
    @ember-data/record-data +29.99 KB +230.0 B (+5.8 KB +37.14 B compressed)
        @ember-data/record-data/-private/record-data +8.16 KB +291.0 B (+1.58 KB +46.99 B compressed)
        @ember-data/record-data/-private/relationships/state/has-many +2.13 KB -62.0 B (+422.19 B -10.01 B compressed)
        @ember-data/record-data/-private/graph/operations/update-relationship +1.42 KB +1.0 B (+280.49 B +0.16 B compressed)
    @ember-data/serializer +21.74 KB -24.0 B (+4.2 KB -3.88 B compressed)
        @ember-data/serializer/json-api +3.69 KB -24.0 B (+731.1 B -3.88 B compressed)
    @ember-data/model +22.09 KB +1.29 KB (+4.27 KB +213.61 B compressed)
        @ember-data/model/-private/model +10.79 KB +1.19 KB (+2.09 KB +196.5 B compressed)
        @ember-data/model/-private/system/many-array +2.42 KB -26.0 B (+479.41 B -4.2 B compressed)
        @ember-data/model/-private/attr +805.0 B +132.0 B (+155.61 B +21.31 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '210.37 KB' │
│ compressed │ '40.67 KB'  │
│  packages  │      8      │
│  modules   │     147     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '99.56 KB' │
│  compressed  │ '19.25 KB' │
│ % Of Library │   '47.3'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.14 KB  | 3.31 KB    | 17.2          | 8.1
	@ember-data/store/-private/system/model/internal-model                             | 16.24 KB  | 3.14 KB    | 16.3          | 7.7
	@ember-data/store/-private/system/model/states                                     | 5.42 KB   | 1.05 KB    | 5.4           | 2.6
	@ember-data/store/-private/system/fetch-manager                                    | 5.00 KB   | 989.36 B   | 5.0           | 2.4
	@ember-data/store/-private/system/store/finders                                    | 4.42 KB   | 875.31 B   | 4.4           | 2.1
	@ember-data/store/-private/index                                                   | 4.11 KB   | 813.64 B   | 4.1           | 2.0
	@ember-data/store/-private/system/record-array-manager                             | 4.11 KB   | 813.64 B   | 4.1           | 2.0
	@ember-data/store/-private/identifiers/cache                                       | 3.88 KB   | 767.25 B   | 3.9           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.36 KB   | 664.79 B   | 3.4           | 1.6
	@ember-data/store/-private/system/snapshot                                         | 3.21 KB   | 634.64 B   | 3.2           | 1.5
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.91 KB   | 576.84 B   | 2.9           | 1.4
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.25 KB   | 445.19 B   | 2.3           | 1.1
	@ember-data/store/-private/system/ds-model-store                                   | 2.00 KB   | 396.48 B   | 2.0           | 1.0
	@ember-data/store/-private/system/request-cache                                    | 1.89 KB   | 373.28 B   | 1.9           | 0.9
	@ember-data/store/-private/system/references/has-many                              | 1.53 KB   | 302.72 B   | 1.5           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.47 KB   | 291.70 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 260.77 B   | 1.3           | 0.6
	@ember-data/store/-private/system/references/belongs-to                            | 1.30 KB   | 257.87 B   | 1.3           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.12 KB   | 222.50 B   | 1.1           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 1.05 KB   | 208.38 B   | 1.1           | 0.5
	@ember-data/store/-private/system/model/notify-changes                             | 1.04 KB   | 205.29 B   | 1.0           | 0.5
	@ember-data/store/-private/system/references/record                                | 979.00 B  | 189.25 B   | 1.0           | 0.5
	@ember-data/store/index                                                            | 936.00 B  | 180.93 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 917.00 B  | 177.26 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 892.00 B  | 172.43 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 869.00 B  | 167.98 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 764.00 B  | 147.69 B   | 0.7           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 145.56 B   | 0.7           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 697.00 B  | 134.73 B   | 0.7           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 115.60 B   | 0.6           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 556.00 B  | 107.48 B   | 0.5           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 506.00 B  | 97.81 B    | 0.5           | 0.2
	@ember-data/store/-private/system/store/common                                     | 505.00 B  | 97.62 B    | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 496.00 B  | 95.88 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 94.14 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 450.00 B  | 86.99 B    | 0.4           | 0.2
	@ember-data/store/-private/system/diff-array                                       | 438.00 B  | 84.67 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 400.00 B  | 77.32 B    | 0.4           | 0.2
	@ember-data/store/-private/utils/symbol                                            | 393.00 B  | 75.97 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 373.00 B  | 72.10 B    | 0.4           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 327.00 B  | 63.21 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 61.08 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 56.06 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 239.00 B  | 46.20 B    | 0.2           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 42.52 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.98 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 193.00 B  | 37.30 B    | 0.2           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 190.00 B  | 36.72 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 98.00 B   | 18.94 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 96.00 B   | 18.55 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 95.00 B   | 18.36 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 95.00 B   | 18.36 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 95.00 B   | 18.36 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 90.00 B   | 17.39 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 89.00 B   | 17.20 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 89.00 B   | 17.20 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 85.00 B   | 16.43 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-instance                           | 85.00 B   | 16.43 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/record-data                               | 81.00 B   | 15.65 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 78.00 B   | 15.07 B    | 0.1           | 0.0
	@ember-data/store/-private/ts-interfaces/utils                                     | 75.00 B   | 14.49 B    | 0.1           | 0.0

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '29.99 KB' │
│  compressed  │ '5.80 KB'  │
│ % Of Library │   '14.3'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.16 KB   | 1.58 KB    | 27.2          | 3.9
	@ember-data/record-data/-private/graph/index                                      | 4.61 KB   | 912.62 B   | 15.4          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 2.87 KB   | 567.36 B   | 9.6           | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.81 KB   | 555.96 B   | 9.4           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.13 KB   | 422.19 B   | 7.1           | 1.0
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.90 KB   | 376.37 B   | 6.3           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.42 KB   | 280.49 B   | 4.7           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.03 KB   | 204.52 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 979.00 B  | 189.25 B   | 3.2           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 188.86 B   | 3.2           | 0.5
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 771.00 B  | 149.04 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 133.77 B   | 2.3           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 650.00 B  | 125.65 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 78.48 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 56.64 B    | 1.0           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 46.00 B    | 0.8           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 100.00 B  | 19.33 B    | 0.3           | 0.0
	@ember-data/record-data/-private/graph/-operations                                | 79.00 B   | 15.27 B    | 0.3           | 0.0

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.09 KB' │
│  compressed  │ '4.27 KB'  │
│ % Of Library │   '10.5'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 10.79 KB  | 2.09 KB    | 48.8          | 5.1
	@ember-data/model/-private/system/many-array                          | 2.42 KB   | 479.41 B   | 11.0          | 1.2
	@ember-data/model/-private/errors                                     | 2.03 KB   | 402.47 B   | 9.2           | 1.0
	@ember-data/model/-private/index                                      | 1.29 KB   | 255.36 B   | 5.8           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.25 KB   | 248.01 B   | 5.7           | 0.6
	@ember-data/model/-private/attr                                       | 805.00 B  | 155.61 B   | 3.6           | 0.4
	@ember-data/model/-private/system/promise-many-array                  | 642.00 B  | 124.10 B   | 2.8           | 0.3
	@ember-data/model/-private/belongs-to                                 | 626.00 B  | 121.01 B   | 2.8           | 0.3
	@ember-data/model/-private/has-many                                   | 587.00 B  | 113.47 B   | 2.6           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 93.94 B    | 2.1           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 85.44 B    | 2.0           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 412.00 B  | 79.64 B    | 1.8           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 408.00 B  | 78.87 B    | 1.8           | 0.2

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.74 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '10.3'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.12 KB   | 1.38 KB    | 32.7          | 3.4
	@ember-data/serializer/-private/embedded-records-mixin     | 4.30 KB   | 850.95 B   | 19.8          | 2.0
	@ember-data/serializer/json-api                            | 3.69 KB   | 731.10 B   | 17.0          | 1.8
	@ember-data/serializer/rest                                | 2.71 KB   | 537.01 B   | 12.5          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 233.90 B   | 5.4           | 0.6
	@ember-data/serializer/-private/transforms/date            | 523.00 B  | 101.10 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 490.00 B  | 94.72 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 446.00 B  | 86.21 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 351.00 B  | 67.85 B    | 1.6           | 0.2
	@ember-data/serializer/-private/utils                      | 286.00 B  | 55.28 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 243.00 B  | 46.97 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 242.00 B  | 46.78 B    | 1.1           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.56 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.14 KB' │
│  compressed  │ '3.51 KB'  │
│ % Of Library │   '8.6'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 8.37 KB   | 1.62 KB    | 46.1          | 4.0
	@ember-data/adapter/error                                     | 1.91 KB   | 378.69 B   | 10.5          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.82 KB   | 360.91 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.14 KB   | 225.01 B   | 6.3           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 204.13 B   | 5.7           | 0.5
	@ember-data/adapter/json-api                                  | 1.02 KB   | 201.62 B   | 5.6           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 792.00 B  | 153.10 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 549.00 B  | 106.12 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 480.00 B  | 92.78 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 87.76 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 347.00 B  | 67.07 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 219.00 B  | 42.33 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 76.00 B   | 14.69 B    | 0.4           | 0.0

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.50 KB' │
│  compressed  │ '1.84 KB' │
│ % Of Library │   '4.5'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.32 KB   | 459.88 B   | 24.5          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 381.59 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 235.25 B   | 12.5          | 0.6
	ember-data/setup-container                        | 503.00 B  | 97.23 B    | 5.2           | 0.2
	ember-data/-private/core                          | 321.00 B  | 62.05 B    | 3.3           | 0.1
	ember-data/relationships                          | 318.00 B  | 61.47 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.96 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 48.52 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 47.36 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.97 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.97 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 46.58 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.81 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.84 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.68 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.91 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.91 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 42.14 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 31.31 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.66 KB' │
│  compressed  │ '1.29 KB' │
│ % Of Library │   '3.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.88 KB   | 570.07 B   | 43.3          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 314.51 B   | 23.9          | 0.8
	ember-inflector/index                             | 473.00 B  | 91.43 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 91.04 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 72.10 B    | 5.5           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 61.47 B    | 4.7           | 0.1
	ember-inflector/lib/utils/make-helper             | 308.00 B  | 59.53 B    | 4.5           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 57.21 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.70 KB'  │
│  compressed  │ '534.50 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.21 KB   | 438.03 B   | 82.0          | 1.1
	@ember-data/debug/setup                           | 499.00 B  | 96.46 B    | 18.0          | 0.2

@github-actions
Copy link

github-actions bot commented May 7, 2021

Performance Report for 8f061f1

Scenario - materialization: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +66ms [47ms to 86ms] OR +2.67% [1.88% to 3.45%]
⚠️ Phase [navigationStart] => [start-find-all]
phase estimated regression +13ms [3ms to 24ms] OR +3.08% [0.77% to 5.46%]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-21ms to 5ms]
⚠️ Phase [start-materialization] => [end-materialization]
phase estimated regression +45ms [39ms to 52ms] OR +5.22% [4.44% to 6.03%]
⚠️ Phase [end-materialization] => [Test End]
phase estimated regression +13ms [10ms to 16ms] OR +18.86% [14.36% to 23.29%]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-33ms to 52ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 13ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -25ms [-45ms to -4ms] OR -1.48% [-2.67% to -0.22%]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +28ms [9ms to 48ms] OR +0.76% [0.24% to 1.31%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - destroy: ⚠️ Performance regressed

⚠️ duration
phase estimated regression +80ms [50ms to 109ms] OR +2.5% [1.55% to 3.39%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-11ms to 12ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-22ms to 16ms]
⚠️ Phase [start-destroy-records] => [end-destroy-records]
phase estimated regression +80ms [73ms to 86ms] OR +10.87% [9.97% to 11.74%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 35ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-9ms to 17ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-13ms to 4ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [0ms to 5ms]
⚠️ Phase [end-push-update-payload] => [Test End]
phase estimated regression +14ms [12ms to 16ms] OR +10.96% [9.51% to 12.45%]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-14ms to 20ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 7ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-24ms to 0ms]
⚠️ Phase [end-push-payload] => [Test End]
phase estimated regression +14ms [12ms to 16ms] OR +10.22% [9.08% to 11.41%]

@runspired
Copy link
Contributor Author

Ilios has 3 test failures, seem to all be in the same unit test module. Will investigate Friday afternoon.

@runspired
Copy link
Contributor Author

The perf jitter here is minimal enough outside of the destroy case that I'm not concerned. The destroy case should be at least offset if not fully addressed and then improved by #7505

The file size increase is slightly concerning: it seems likely we did not flag for removal enough of the old code paths. Hopefully once we begin cleanup where we missed things will become evident.

@runspired
Copy link
Contributor Author

Not sure why the prod IE11 scenario failed here, can't spot anything that specifically seems IE11 problematic, don't have easy access to a VM with IE11 to debug either.

@runspired runspired added this to In Development in 🌲 Project Trim 🌲 via automation May 11, 2021
@runspired runspired added this to In Development in Feature Work via automation May 11, 2021
@runspired runspired moved this from In Development to Ready To Ship in 🌲 Project Trim 🌲 May 11, 2021
@runspired runspired moved this from In Development to Ready To Ship in Feature Work May 11, 2021
@runspired runspired merged commit f76a0e0 into master May 11, 2021
🌲 Project Trim 🌲 automation moved this from Ready To Ship to Completed May 11, 2021
Feature Work automation moved this from Ready To Ship to Completed May 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/all-the-flags branch May 11, 2021 05:52
@runspired runspired added the 🎯 beta PR should be backported to beta label May 11, 2021
@runspired runspired removed the 🎯 beta PR should be backported to beta label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ feat This PR introduces a new feature
Projects
No open projects
Feature Work
  
Completed
Development

Successfully merging this pull request may close these issues.

None yet

2 participants