Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Fixes JSONAPISerializer serialize documentation #7549

Merged
merged 3 commits into from
May 27, 2021
Merged

[DOC] Fixes JSONAPISerializer serialize documentation #7549

merged 3 commits into from
May 27, 2021

Conversation

iamdtang
Copy link

@iamdtang iamdtang commented May 26, 2021 •
edited
Loading

Fixes #7479

I took the description for JSONSerializer#serialize and reworked it for JSONAPISerializer#serialize to some symmetry.

@runspired runspired added the 🏷️ doc This PR adds/improves/or fixes documentation label May 26, 2021
@runspired runspired added this to In Development in Documentation via automation May 26, 2021
@iamdtang iamdtang force-pushed the wrong-json-api-serializer-imports branch from 4089c07 to 321a342 Compare May 27, 2021 06:19
@runspired
Apply suggestions from code review
a8bc031 
Cleaned up some wording to ensure folks don't confuse JSON with JSON:API

Fixed issue with what value `serialize` is called with when called from the JSONAPIAdapter
Documentation automation moved this from In Development to Ready To Ship May 27, 2021
@runspired runspired merged commit bf30d50 into emberjs:master May 27, 2021
Documentation automation moved this from Ready To Ship to Completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runspired runspired runspired approved these changes

Assignees
No one assigned
Labels
🏷️ doc This PR adds/improves/or fixes documentation
Projects
No open projects
Documentation
  
Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wrong JSONAPISerializer imports
2 participants
@iamdtang @runspired