Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests #7703

Merged
merged 6 commits into from
Sep 17, 2021
Merged

fix tests #7703

merged 6 commits into from
Sep 17, 2021

Commits on Sep 11, 2021

  1. [cleanup]: rm unused flags

    @snewcomer
    snewcomer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    198eba7 View commit details
    Browse the repository at this point in the history

  2. tmp remove

    @snewcomer
    snewcomer committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    d81f022 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2021

  1. fix stuck test. requestPromise is already resolved in previous steps

    @snewcomer
    snewcomer committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    4f5fdca View commit details
    Browse the repository at this point in the history

  2. improve test slightly

    @snewcomer
    snewcomer committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    2b22be8 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. .then on requestPromise to ensure test doesnt hang

    @snewcomer
    snewcomer committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    af375be View commit details
    Browse the repository at this point in the history

  2. add back for libraries

    @snewcomer
    snewcomer committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    8bd7d39 View commit details
    Browse the repository at this point in the history