fix: rollbackAttributes|unloadRecord during hasMany forEach should not error #7900

runspired · 2022-02-24T03:10:47Z

This issue has existed for so long we shouldn't backport unless requested.

github-actions · 2022-02-24T03:18:32Z

Asset Size Report for 7782458

Modern Builds

🛑 The size of the library EmberData has increased by +178.0 B (+38.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/model has increased by +178.0 B.

Changeset


EmberData +184.23 KB +178.0 B (+39.12 KB +38.0 B compressed)
    @ember-data/model +29.13 KB +178.0 B (+6.19 KB +38.0 B compressed)
        @ember-data/model/-private +28.66 KB +178.0 B (+6.08 KB +38.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '184.23 KB' │
│ compressed │ '39.12 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '76.41 KB' │
│  compressed  │ '16.22 KB' │
│ % Of Library │   '41.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 75.50 KB  | 16.03 KB   | 98.8          | 41.0
	@ember-data/store/index                           | 936.00 B  | 198.73 B   | 1.2           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '29.13 KB' │
│  compressed  │ '6.19 KB'  │
│ % Of Library │   '15.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.66 KB  | 6.08 KB    | 98.4          | 15.6
	@ember-data/model/index                           | 486.00 B  | 103.18 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.12 KB' │
│  compressed  │ '5.12 KB'  │
│ % Of Library │   '13.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.12 KB  | 5.12 KB    | 100.0         | 13.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.83 KB' │
│  compressed  │ '4.21 KB'  │
│ % Of Library │   '10.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.23 KB   | 1.53 KB    | 36.4          | 3.9
	@ember-data/serializer/-private                   | 5.54 KB   | 1.18 KB    | 27.9          | 3.0
	@ember-data/serializer/json-api                   | 3.75 KB   | 814.88 B   | 18.9          | 2.0
	@ember-data/serializer/rest                       | 2.85 KB   | 620.61 B   | 14.4          | 1.5
	@ember-data/serializer/index                      | 258.00 B  | 54.77 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 45.64 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.84 KB' │
│  compressed  │ '3.36 KB'  │
│ % Of Library │   '8.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.99 KB   | 1.70 KB    | 50.4          | 4.3
	@ember-data/adapter/-private                      | 3.79 KB   | 824.86 B   | 24.0          | 2.1
	@ember-data/adapter/error                         | 1.99 KB   | 432.92 B   | 12.6          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 225.27 B   | 6.5           | 0.6
	@ember-data/adapter/json-api                      | 1.03 KB   | 224.84 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '1.98 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 525.70 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 462.43 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 258.39 B   | 12.7          | 0.6
	ember-data/setup-container                        | 368.00 B  | 78.13 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.51 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.17 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.29 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.01 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.59 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.59 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.16 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.31 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.25 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.98 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.13 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.13 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.28 B    | 2.3           | 0.1
	ember-data/version                                | 162.00 B  | 34.39 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.43 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 654.36 B   | 44.7          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 345.44 B   | 23.6          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 100.00 B   | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 80.46 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 79.19 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 74.73 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.51 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.84 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '612.33 B' │
│ % Of Library │   '1.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 505.10 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 107.22 B   | 17.5          | 0.3

Modern Builds (No Rollup)

🛑 The size of the library EmberData has increased by +178.0 B (+30.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/model has increased by +178.0 B.

Changeset


EmberData +222.85 KB +178.0 B (+42.1 KB +30.0 B compressed)
    @ember-data/model +33.2 KB +178.0 B (+6.27 KB +30.0 B compressed)
        @ember-data/model/-private/system/many-array +3.01 KB +178.0 B (+582.61 B +30.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '222.85 KB' │
│ compressed │ '42.10 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '99.14 KB' │
│  compressed  │ '18.73 KB' │
│ % Of Library │   '44.5'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 15.42 KB  | 2.91 KB    | 15.5          | 6.9
	@ember-data/store/-private/system/model/internal-model                             | 14.65 KB  | 2.77 KB    | 14.8          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.49 KB   | 1.04 KB    | 5.5           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.26 KB   | 1018.43 B  | 5.3           | 2.4
	@ember-data/store/-private/system/record-array-manager                             | 4.16 KB   | 804.77 B   | 4.2           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.88 KB   | 751.31 B   | 3.9           | 1.7
	@ember-data/store/-private/system/store/finders                                    | 3.54 KB   | 684.62 B   | 3.6           | 1.6
	@ember-data/store/-private/system/references/has-many                              | 3.48 KB   | 674.04 B   | 3.5           | 1.6
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.28 KB   | 634.93 B   | 3.3           | 1.5
	@ember-data/store/-private/index                                                   | 3.24 KB   | 627.00 B   | 3.3           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.04 KB   | 588.84 B   | 3.1           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.88 KB   | 556.35 B   | 2.9           | 1.3
	@ember-data/store/-private/system/references/belongs-to                            | 2.87 KB   | 554.46 B   | 2.9           | 1.3
	@ember-data/store/-private/system/references/record                                | 2.23 KB   | 431.29 B   | 2.2           | 1.0
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.22 KB   | 429.96 B   | 2.2           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.80 KB   | 348.54 B   | 1.8           | 0.8
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 345.71 B   | 1.8           | 0.8
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 293.38 B   | 1.5           | 0.7
	@ember-data/store/-private/system/model/shim-model-class                           | 1.41 KB   | 272.79 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 220.65 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 188.72 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 176.82 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 922.00 B  | 174.17 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 904.00 B  | 170.77 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 167.37 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 151.50 B   | 0.8           | 0.4
	@ember-data/store/-private/system/record-notification-manager                      | 783.00 B  | 147.91 B   | 0.8           | 0.3
	@ember-data/store/-private/system/snapshot-record-array                            | 769.00 B  | 145.27 B   | 0.8           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 132.05 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 115.04 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 604.00 B  | 114.10 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 112.97 B   | 0.6           | 0.3
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 93.32 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.00 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 85.76 B    | 0.4           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 447.00 B  | 84.44 B    | 0.4           | 0.2
	@ember-data/store/-private/system/weak-cache                                       | 416.00 B  | 78.58 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 65.74 B    | 0.3           | 0.2
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 59.69 B    | 0.3           | 0.1
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 313.00 B  | 59.13 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 54.78 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.19 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.56 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.04 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 39.67 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 31.92 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.54 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.35 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.35 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.35 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.41 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.22 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.22 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.47 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.47 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.71 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.14 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.58 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.58 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '33.20 KB' │
│  compressed  │ '6.27 KB'  │
│ % Of Library │   '14.9'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.97 KB   | 1.88 KB    | 30.0          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.18 KB    | 18.8          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.95 KB   | 763.59 B   | 11.9          | 1.8
	@ember-data/model/-private/system/many-array                          | 3.01 KB   | 582.61 B   | 9.1           | 1.4
	@ember-data/model/-private/errors                                     | 2.05 KB   | 396.53 B   | 6.2           | 0.9
	@ember-data/model/-private/index                                      | 1.42 KB   | 275.05 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 252.57 B   | 3.9           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 165.11 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 159.63 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 129.97 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 122.41 B   | 1.9           | 0.3
	@ember-data/model/-private/util                                       | 526.00 B  | 99.36 B    | 1.5           | 0.2
	@ember-data/model/index                                               | 486.00 B  | 91.81 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 85.38 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 84.44 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 80.66 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.23 KB' │
│  compressed  │ '5.90 KB'  │
│ % Of Library │   '14.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.57 KB    | 26.5          | 3.7
	@ember-data/record-data/-private/graph/index                                      | 4.96 KB   | 959.87 B   | 15.9          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.21 KB   | 620.39 B   | 10.3          | 1.4
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.87 KB   | 555.40 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 393.88 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 374.80 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 292.24 B   | 4.8           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.06 KB   | 204.97 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 204.21 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 184.56 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 150.75 B   | 2.5           | 0.3
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 130.72 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 127.89 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 76.69 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.35 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 44.96 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.30 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.33 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.25 KB' │
│  compressed  │ '4.20 KB'  │
│ % Of Library │   '10.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.23 KB   | 1.37 KB    | 32.5          | 3.2
	@ember-data/serializer/-private/embedded-records-mixin     | 4.43 KB   | 857.85 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 725.05 B   | 16.8          | 1.7
	@ember-data/serializer/rest                                | 2.85 KB   | 552.19 B   | 12.8          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 228.58 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 100.12 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 96.53 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 85.57 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 71.97 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.24 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 48.73 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 42.69 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 40.61 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.97 KB' │
│  compressed  │ '3.39 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.99 KB   | 1.51 KB    | 44.4          | 3.6
	@ember-data/adapter/error                                     | 1.99 KB   | 385.19 B   | 11.1          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 374.04 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 200.43 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.03 KB   | 200.05 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 199.49 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 770.00 B  | 145.46 B   | 4.2           | 0.3
	@ember-data/adapter/-private/utils/determine-body-promise     | 573.00 B  | 108.24 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 93.32 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 85.76 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 367.00 B  | 69.33 B    | 2.0           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 41.93 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 27.77 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.80 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 467.74 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 372.91 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 229.90 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 69.52 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 69.52 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.07 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 51.76 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.41 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.28 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 45.90 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 45.90 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.52 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 44.77 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 43.82 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 42.69 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 41.93 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 41.93 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.18 B    | 2.2           | 0.1
	ember-data/version                                | 162.00 B  | 30.60 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.74 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 3.01 KB   | 582.22 B   | 44.7          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 307.36 B   | 23.6          | 0.7
	ember-inflector/lib/system                        | 471.00 B  | 88.97 B    | 6.8           | 0.2
	ember-inflector/index                             | 379.00 B  | 71.59 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 70.46 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 66.49 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.07 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 55.91 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '544.82 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 449.41 B   | 82.5          | 1.0
	@ember-data/debug/setup                           | 505.00 B  | 95.40 B    | 17.5          | 0.2

runspired · 2022-02-24T03:27:44Z

cc @josh-fnbtech

github-actions · 2022-02-24T03:51:20Z

Performance Report for 7782458

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-28ms to 38ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-21ms to 5ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-15ms to 12ms]
⚠️ Phase [start-materialization] => [end-materialization]
phase estimated regression +14ms [3ms to 25ms] OR +2.32% [0.56% to 4.09%]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-9ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-30ms to 35ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 24ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-31ms to 10ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-3ms to 11ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-2ms to 1ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-35ms to 40ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-18ms to 17ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-25ms to 14ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 22ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 3ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-22ms to 23ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-14ms to 23ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-15ms to 6ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 6ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 4ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-30ms to 20ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-14ms to 16ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-21ms to 9ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 1ms]

runspired added 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Feb 24, 2022

fix

3fefaa6

runspired force-pushed the runspired/fix-iteration-bug branch from 7782458 to 3fefaa6 Compare December 7, 2022 08:59

runspired merged commit 4f463f2 into master Dec 7, 2022

delete-merged-branch bot deleted the runspired/fix-iteration-bug branch December 7, 2022 09:25

runspired mentioned this pull request Apr 27, 2023

deleteRecord/unloadRecord causing peekAll to return undefined records #8583

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: rollbackAttributes|unloadRecord during hasMany forEach should not error #7900

fix: rollbackAttributes|unloadRecord during hasMany forEach should not error #7900

runspired commented Feb 24, 2022

github-actions bot commented Feb 24, 2022 •

edited

Loading

Warnings

Warnings

runspired commented Feb 24, 2022

github-actions bot commented Feb 24, 2022

fix: rollbackAttributes|unloadRecord during hasMany forEach should not error #7900

fix: rollbackAttributes|unloadRecord during hasMany forEach should not error #7900

Conversation

runspired commented Feb 24, 2022

github-actions bot commented Feb 24, 2022 • edited Loading

Warnings

Warnings

runspired commented Feb 24, 2022

github-actions bot commented Feb 24, 2022

github-actions bot commented Feb 24, 2022 •

edited

Loading