Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix earlier versions of node-14 #8108

Merged
merged 1 commit into from Aug 9, 2022
Merged

fix earlier versions of node-14 #8108

merged 1 commit into from Aug 9, 2022

Conversation

runspired
Copy link
Contributor

resolves #8100

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue labels Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Asset Size Report for 77ebc70

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '177.78 KB' │
│ compressed │ '37.07 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '51.01 KB' │
│  compressed  │ '10.64 KB' │
│ % Of Library │   '28.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 50.01 KB  | 10.43 KB   | 98.0          | 28.1
	@ember-data/store/index                           | 1022.00 B | 213.12 B   | 2.0           | 0.6

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '47.24 KB' │
│  compressed  │ '9.85 KB'  │
│ % Of Library │   '26.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 46.77 KB  | 9.75 KB    | 99.0          | 26.3
	@ember-data/model/index                           | 486.00 B  | 101.34 B   | 1.0           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.53 KB' │
│  compressed  │ '5.11 KB'  │
│ % Of Library │   '13.8'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.53 KB  | 5.11 KB    | 100.0         | 13.8

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.72 KB' │
│  compressed  │ '4.32 KB'  │
│ % Of Library │   '11.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.55 KB   | 1.58 KB    | 36.5          | 4.2
	@ember-data/serializer/-private                   | 5.67 KB   | 1.18 KB    | 27.4          | 3.2
	@ember-data/serializer/json-api                   | 3.80 KB   | 810.79 B   | 18.3          | 2.1
	@ember-data/serializer/rest                       | 2.89 KB   | 617.89 B   | 14.0          | 1.6
	@ember-data/serializer/index                      | 611.00 B  | 127.41 B   | 2.9           | 0.3
	@ember-data/serializer/transform                  | 215.00 B  | 44.83 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.32 KB'  │
│ % Of Library │   '9.0'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.64 KB    | 49.5          | 4.4
	@ember-data/adapter/-private                      | 3.79 KB   | 808.28 B   | 23.8          | 2.1
	@ember-data/adapter/error                         | 1.82 KB   | 389.13 B   | 11.4          | 1.0
	@ember-data/adapter/index                         | 1.41 KB   | 301.54 B   | 8.9           | 0.8
	@ember-data/adapter/json-api                      | 1.03 KB   | 220.84 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.77 KB' │
│  compressed  │ '1.83 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.14 KB   | 457.53 B   | 24.4          | 1.2
	ember-data/-private                               | 1.83 KB   | 389.96 B   | 20.8          | 1.0
	ember-data/adapters/errors                        | 1.19 KB   | 253.78 B   | 13.5          | 0.7
	ember-data/setup-container                        | 368.00 B  | 76.74 B    | 4.1           | 0.2
	ember-data/relationships                          | 318.00 B  | 66.31 B    | 3.5           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 57.13 B    | 3.1           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 52.34 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.09 B    | 2.7           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 50.67 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 50.67 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 50.25 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 49.42 B    | 2.6           | 0.1
	ember-data/serializer                             | 232.00 B  | 48.38 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.12 B    | 2.5           | 0.1
	ember-data/model                                  | 222.00 B  | 46.29 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 46.29 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 45.46 B    | 2.4           | 0.1
	ember-data/version                                | 161.00 B  | 33.57 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.39 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 632.69 B   | 44.4          | 1.7
	ember-inflector/lib/system/inflections            | 1.59 KB   | 339.28 B   | 23.8          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 98.22 B    | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 79.03 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 76.94 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 69.23 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 66.31 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 61.72 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.91 KB'  │
│  compressed  │ '621.64 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.42 KB   | 516.33 B   | 83.1          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 105.30 B   | 16.9          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Performance Report for 77ebc70

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-23ms to 21ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-8ms to 4ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-10ms to 9ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-8ms to 7ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-7ms to 0ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-20ms to 20ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 12ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-15ms to 4ms]
⚠️ Phase [start-unload-records] => [end-unload-records]
phase estimated regression +4ms [0ms to 9ms] OR +1.16% [0.02% to 2.41%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-26ms to 21ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 12ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-11ms to 9ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-9ms to 5ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 23ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-8ms to 17ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-1ms to 8ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-3ms to 3ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-2ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-25ms to 12ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-11ms to 11ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-13ms to 8ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-5ms to 1ms]

@runspired runspired merged commit eef2348 into master Aug 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/node-14 branch August 9, 2022 08:16
runspired added a commit that referenced this pull request Aug 23, 2022
Co-authored-by: Chris Thoburn <runspired@users.noreply.github.com>
@jrjohnson jrjohnson removed the 🎯 release PR should be backported to release label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken on node versions 14.8.0 to 14.17.6
2 participants