Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add release perf check #8151

Merged
merged 4 commits into from
Aug 26, 2022
Merged

chore: add release perf check #8151

merged 4 commits into from
Aug 26, 2022

Conversation

runspired
Copy link
Contributor

lets us measure against the current release branch. May require that we catch the perf-test harness on release-branch up to speed.

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Aug 25, 2022
@github-actions
Copy link

github-actions bot commented Aug 25, 2022

Asset Size Report for 228caed

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '168.22 KB' │
│ compressed │ '35.63 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '46.99 KB' │
│  compressed  │ '9.95 KB'  │
│ % Of Library │   '27.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 46.00 KB  | 9.74 KB    | 97.9          | 27.3
	@ember-data/store/index                           | 1022.00 B | 216.45 B   | 2.1           | 0.6

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.78 KB' │
│  compressed  │ '9.48 KB'  │
│ % Of Library │   '26.6'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.31 KB  | 9.38 KB    | 98.9          | 26.3
	@ember-data/model/index                           | 486.00 B  | 102.93 B   | 1.1           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.33 KB' │
│  compressed  │ '4.73 KB'  │
│ % Of Library │   '13.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 22.33 KB  | 4.73 KB    | 100.0         | 13.3

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.32 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.56 KB    | 36.0          | 4.4
	@ember-data/serializer/-private                   | 5.60 KB   | 1.19 KB    | 27.4          | 3.3
	@ember-data/serializer/json-api                   | 3.79 KB   | 821.95 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 621.39 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 129.40 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.53 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.37 KB'  │
│ % Of Library │   '9.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.67 KB    | 49.5          | 4.7
	@ember-data/adapter/-private                      | 3.79 KB   | 820.89 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 395.20 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 306.24 B   | 8.9           | 0.8
	@ember-data/adapter/json-api                      | 1.03 KB   | 224.28 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.76 KB' │
│ % Of Library │   '4.9'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 430.35 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 332.72 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 257.74 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 77.93 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.34 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.03 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.15 B    | 2.9           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.88 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.46 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.46 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.04 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.19 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.13 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.86 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.01 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.01 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.17 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.09 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.41 KB' │
│ % Of Library │   '4.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 642.57 B   | 44.4          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 344.58 B   | 23.8          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 99.75 B    | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 80.26 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.15 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.31 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.34 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.68 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '600.00 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 493.04 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 106.95 B   | 17.8          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬──────────┐
│  (index)   │  Values  │
├────────────┼──────────┤
│   bytes    │ '0.00 B' │
│ compressed │ '1.00 B' │
│  packages  │    0     │
│  modules   │    0     │
└────────────┴──────────┘

@github-actions
Copy link

github-actions bot commented Aug 25, 2022

Performance Report for 228caed

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-54ms to 2ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-3ms to 3ms]
✅ Phase [start-data-generation] => [start-push-payload]
phase estimated improvement -7ms [-11ms to -4ms] OR -1.44% [-2.06% to -0.83%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-21ms to 0ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-19ms to 10ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-7ms to 0ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-10ms to 8ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-4ms to 2ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-5ms to 3ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-2ms to 4ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-45ms to 27ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 1ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 0ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-7ms to 4ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-5ms to 4ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-32ms to 25ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-5ms to 10ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 13ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 5ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-5ms to 6ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-1ms to 2ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 10ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-6ms to 4ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-9ms to 4ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-6ms to 1ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-5ms to 4ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-14ms to 8ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-6ms to 5ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-5ms to 3ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-2ms to 2ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 10ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-6ms to 9ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-2ms to 2ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-2ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-12ms to 6ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 4ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-7ms to 2ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@github-actions
Copy link

Commit v Release Performance Report for 228caed

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -2006ms [-2073ms to -1913ms] OR -35.43% [-36.6% to -33.79%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-1ms to 10ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-6ms to 3ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -997ms [-1016ms to -978ms] OR -34.3% [-34.98% to -33.65%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -128ms [-130ms to -126ms] OR -96.63% [-97.97% to -95.02%]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -375ms [-396ms to -356ms] OR -28.66% [-30.28% to -27.27%]
✅ Phase [end-record-materialization] => [Test End]
phase estimated improvement -204ms [-547ms to -176ms] OR -76.53% [-205.23% to -66.03%]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -474ms [-490ms to -457ms] OR -36.25% [-37.5% to -34.94%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-9ms to 6ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -72ms [-81ms to -64ms] OR -14.79% [-16.57% to -13.17%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -314ms [-318ms to -309ms] OR -75.6% [-76.54% to -74.57%]
✅ Phase [end-materialization] => [Test End]
phase estimated improvement -81ms [-84ms to -79ms] OR -66.57% [-68.43% to -64.63%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -1334ms [-1406ms to -1263ms] OR -19.24% [-20.27% to -18.22%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-4ms to 8ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 4ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -402ms [-414ms to -390ms] OR -29.43% [-30.32% to -28.53%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -59ms [-61ms to -57ms] OR -95.85% [-98.31% to -92.69%]
✅ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated improvement -272ms [-278ms to -266ms] OR -48.66% [-49.78% to -47.62%]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -432ms [-504ms to -364ms] OR -11.08% [-12.91% to -9.32%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -174ms [-184ms to -164ms] OR -29.59% [-31.35% to -27.8%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -320ms [-333ms to -306ms] OR -20.38% [-21.22% to -19.46%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 6ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -184ms [-193ms to -175ms] OR -23.05% [-24.12% to -21.89%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -130ms [-134ms to -125ms] OR -40.3% [-41.76% to -38.71%]
✅ Phase [end-unload-records] => [Test End]
phase estimated improvement -1ms [-2ms to 0ms] OR -2.48% [-4.32% to -0.75%]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -17159ms [-17250ms to -17076ms] OR -86.37% [-86.83% to -85.95%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 25ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -617ms [-634ms to -595ms] OR -33.26% [-34.22% to -32.11%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -458ms [-465ms to -451ms] OR -54.23% [-55.02% to -53.38%]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -16110ms [-16196ms to -16037ms] OR -97.37% [-97.89% to -96.93%]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -2ms [-3ms to -1ms] OR -4.06% [-5.88% to -2.31%]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -465ms [-480ms to -451ms] OR -26.89% [-27.75% to -26.05%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-11ms to 5ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -163ms [-169ms to -156ms] OR -21% [-21.86% to -20.11%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -300ms [-305ms to -295ms] OR -58.84% [-59.83% to -57.78%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -202ms [-213ms to -191ms] OR -18.47% [-19.48% to -17.47%]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-13ms to 3ms]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -77ms [-81ms to -74ms] OR -25.59% [-26.87% to -24.37%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -75ms [-78ms to -71ms] OR -28.34% [-29.55% to -27.07%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -42ms [-44ms to -41ms] OR -52.03% [-53.64% to -50.69%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -214ms [-227ms to -201ms] OR -16.77% [-17.73% to -15.73%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 10ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -184ms [-191ms to -177ms] OR -22.97% [-23.86% to -22.1%]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -31ms [-32ms to -30ms] OR -43.61% [-45.25% to -41.8%]

@runspired runspired merged commit 4c79d32 into master Aug 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the perf/release branch August 26, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant