Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port test from #6147 #8160

Merged
merged 2 commits into from
Sep 2, 2022
Merged

port test from #6147 #8160

merged 2 commits into from
Sep 2, 2022

Conversation

runspired
Copy link
Contributor

@runspired runspired commented Sep 2, 2022

the test now passes showing recent relationship refactoring resolved this long standing issue in #6146

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ test This PR primarily adds tests for a feature labels Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Asset Size Report for 685e60c

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '163.11 KB' │
│ compressed │ '34.86 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.71 KB' │
│  compressed  │ '9.56 KB'  │
│ % Of Library │   '27.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.23 KB  | 9.45 KB    | 98.9          | 27.1
	@ember-data/model/index                           | 486.00 B  | 103.87 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.30 KB' │
│  compressed  │ '9.04 KB'  │
│ % Of Library │   '25.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.31 KB  | 8.83 KB    | 97.6          | 25.3
	@ember-data/store/index                           | 1022.00 B | 218.43 B   | 2.4           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '21.99 KB' │
│  compressed  │ '4.70 KB'  │
│ % Of Library │   '13.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 21.99 KB  | 4.70 KB    | 100.0         | 13.5

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.36 KB'  │
│ % Of Library │   '12.5'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.57 KB    | 36.0          | 4.5
	@ember-data/serializer/-private                   | 5.60 KB   | 1.20 KB    | 27.4          | 3.4
	@ember-data/serializer/json-api                   | 3.79 KB   | 829.47 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 627.07 B   | 14.0          | 1.8
	@ember-data/serializer/index                      | 611.00 B  | 130.58 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.95 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '9.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.68 KB    | 49.5          | 4.8
	@ember-data/adapter/-private                      | 3.79 KB   | 828.40 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 398.81 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 309.05 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 226.33 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.78 KB' │
│ % Of Library │   '5.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 434.29 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 335.76 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 260.10 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.65 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.96 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.56 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.64 B    | 2.9           | 0.2
	ember-data/adapters/json-api                      | 245.00 B  | 52.36 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.50 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.65 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.58 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.30 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.59 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.41 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.42 KB' │
│ % Of Library │   '4.1'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 648.45 B   | 44.4          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 347.73 B   | 23.8          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.66 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 81.00 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.86 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.95 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.96 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.26 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '605.49 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 497.55 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 107.93 B   | 17.8          | 0.3

Modern Builds (No Rollup)

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '202.12 KB' │
│ compressed │ '38.59 KB'  │
│  packages  │      8      │
│  modules   │     124     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '63.85 KB' │
│  compressed  │ '12.19 KB' │
│ % Of Library │   '31.6'   │
└──────────────┴────────────┘
	Module                                                                        | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/store-service                                      | 10.69 KB  | 2.04 KB    | 16.7          | 5.3
	@ember-data/store/-private/managers/record-data-manager                       | 7.77 KB   | 1.48 KB    | 12.2          | 3.8
	@ember-data/store/-private/caches/instance-cache                              | 5.76 KB   | 1.10 KB    | 9.0           | 2.8
	@ember-data/store/-private/network/fetch-manager                              | 4.89 KB   | 955.23 B   | 7.7           | 2.4
	@ember-data/store/-private/record-arrays/identifier-array                     | 4.27 KB   | 834.56 B   | 6.7           | 2.1
	@ember-data/store/-private/caches/identifier-cache                            | 3.64 KB   | 712.55 B   | 5.7           | 1.8
	@ember-data/store/-private/network/snapshot                                   | 3.31 KB   | 647.25 B   | 5.2           | 1.6
	@ember-data/store/-private/managers/record-array-manager                      | 3.07 KB   | 600.86 B   | 4.8           | 1.5
	@ember-data/store/-private/index                                              | 2.74 KB   | 534.80 B   | 4.3           | 1.4
	@ember-data/store/-private/proxies/promise-proxies                            | 1.68 KB   | 328.02 B   | 2.6           | 0.8
	@ember-data/store/-private/managers/record-data-store-wrapper                 | 1.62 KB   | 317.32 B   | 2.5           | 0.8
	@ember-data/store/-private/network/request-cache                              | 1.61 KB   | 313.89 B   | 2.5           | 0.8
	@ember-data/store/-private/legacy-model-support/shim-model-class              | 1.55 KB   | 302.24 B   | 2.4           | 0.8
	@ember-data/store/-private/network/finders                                    | 1.51 KB   | 295.94 B   | 2.4           | 0.7
	@ember-data/store/-private/legacy-model-support/schema-definition-service     | 1.37 KB   | 268.64 B   | 2.2           | 0.7
	@ember-data/store/-private/legacy-model-support/record-reference              | 1.34 KB   | 261.76 B   | 2.1           | 0.7
	@ember-data/store/index                                                       | 1022.00 B | 195.13 B   | 1.6           | 0.5
	@ember-data/store/-private/utils/uuid-polyfill                                | 786.00 B  | 150.07 B   | 1.2           | 0.4
	@ember-data/store/-private/managers/record-notification-manager               | 753.00 B  | 143.77 B   | 1.2           | 0.4
	@ember-data/store/-private/network/snapshot-record-array                      | 691.00 B  | 131.93 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/construct-resource                           | 688.00 B  | 131.36 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/common                                       | 572.00 B  | 109.21 B   | 0.9           | 0.3
	@ember-data/store/-private/utils/coerce-id                                    | 473.00 B  | 90.31 B    | 0.7           | 0.2
	@ember-data/store/-private/proxies/promise-proxy-base                         | 403.00 B  | 76.94 B    | 0.6           | 0.2
	@ember-data/store/-private/caches/record-data-for                             | 325.00 B  | 62.05 B    | 0.5           | 0.2
	@ember-data/store/-private/utils/identifer-debug-consts                       | 304.00 B  | 58.04 B    | 0.5           | 0.1
	@ember-data/store/-private/utils/promise-record                               | 291.00 B  | 55.56 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/serializer-response                          | 258.00 B  | 49.26 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/normalize-model-name                         | 219.00 B  | 41.81 B    | 0.3           | 0.1
	@ember-data/store/-debug/index                                                | 207.00 B  | 39.52 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                          | 204.00 B  | 38.95 B    | 0.3           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '51.05 KB' │
│  compressed  │ '9.75 KB'  │
│ % Of Library │   '25.3'   │
└──────────────┴────────────┘
	Module                                                      | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                            | 11.25 KB  | 2.15 KB    | 22.0          | 5.6
	@ember-data/model/-private/legacy-relationships-support     | 7.90 KB   | 1.51 KB    | 15.5          | 3.9
	@ember-data/model/-private/record-state                     | 6.52 KB   | 1.25 KB    | 12.8          | 3.2
	@ember-data/model/-private/references/has-many              | 3.20 KB   | 625.87 B   | 6.3           | 1.6
	@ember-data/model/-private/references/belongs-to            | 2.81 KB   | 550.07 B   | 5.5           | 1.4
	@ember-data/model/-private/promise-many-array               | 2.70 KB   | 528.30 B   | 5.3           | 1.3
	@ember-data/model/-private/legacy-data-fetch                | 2.59 KB   | 505.58 B   | 5.1           | 1.3
	@ember-data/model/-private/many-array                       | 2.35 KB   | 459.00 B   | 4.6           | 1.2
	@ember-data/model/-private/errors                           | 2.31 KB   | 451.55 B   | 4.5           | 1.1
	@ember-data/model/-private/index                            | 1.48 KB   | 290.02 B   | 2.9           | 0.7
	@ember-data/model/-private/relationship-meta                | 991.00 B  | 189.21 B   | 1.9           | 0.5
	@ember-data/model/-private/notify-changes                   | 913.00 B  | 174.32 B   | 1.7           | 0.4
	@ember-data/model/-private/attr                             | 839.00 B  | 160.19 B   | 1.6           | 0.4
	@ember-data/model/-private/has-many                         | 817.00 B  | 155.99 B   | 1.6           | 0.4
	@ember-data/model/-private/belongs-to                       | 736.00 B  | 140.52 B   | 1.4           | 0.4
	@ember-data/model/-private/deprecated-promise-proxy         | 681.00 B  | 130.02 B   | 1.3           | 0.3
	@ember-data/model/-private/promise-belongs-to               | 615.00 B  | 117.42 B   | 1.2           | 0.3
	@ember-data/model/-private/util                             | 522.00 B  | 99.66 B    | 1.0           | 0.3
	@ember-data/model/index                                     | 486.00 B  | 92.79 B    | 0.9           | 0.2
	@ember-data/model/-private/diff-array                       | 445.00 B  | 84.96 B    | 0.9           | 0.2
	@ember-data/model/-private/model-for-mixin                  | 407.00 B  | 77.70 B    | 0.8           | 0.2
	@ember-data/model/-private/legacy-data-utils                | 395.00 B  | 75.41 B    | 0.8           | 0.2
	@ember-data/model/-private/promise-proxy-base               | 284.00 B  | 54.22 B    | 0.5           | 0.1

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.68 KB' │
│  compressed  │ '5.48 KB'  │
│ % Of Library │   '14.2'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 6.99 KB   | 1.33 KB    | 24.4          | 3.5
	@ember-data/record-data/-private/graph/index                                      | 5.88 KB   | 1.12 KB    | 20.5          | 2.9
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.63 KB   | 710.45 B   | 12.7          | 1.8
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.97 KB   | 580.24 B   | 10.3          | 1.5
	@ember-data/record-data/-private/graph/-utils                                     | 2.10 KB   | 411.45 B   | 7.3           | 1.0
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.37 B   | 5.3           | 0.7
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.21 KB   | 236.56 B   | 4.2           | 0.6
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 829.00 B  | 158.28 B   | 2.8           | 0.4
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 708.00 B  | 135.17 B   | 2.4           | 0.3
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 707.00 B  | 134.98 B   | 2.4           | 0.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 692.00 B  | 132.12 B   | 2.4           | 0.3
	@ember-data/record-data/-private/index                                            | 497.00 B  | 94.89 B    | 1.7           | 0.2
	@ember-data/record-data/-private/coerce-id                                        | 379.00 B  | 72.36 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.94 B    | 1.0           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.44 B    | 0.8           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.63 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.43 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.36 KB   | 1.40 KB    | 32.8          | 3.6
	@ember-data/serializer/-private/embedded-records-mixin     | 4.59 KB   | 898.14 B   | 20.5          | 2.3
	@ember-data/serializer/json-api                            | 3.79 KB   | 741.00 B   | 16.9          | 1.9
	@ember-data/serializer/rest                                | 2.87 KB   | 560.19 B   | 12.8          | 1.4
	@ember-data/serializer/-private/index                      | 1018.00 B | 194.36 B   | 4.4           | 0.5
	@ember-data/serializer/index                               | 611.00 B  | 116.65 B   | 2.7           | 0.3
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.19 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 504.00 B  | 96.22 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 439.00 B  | 83.81 B    | 1.9           | 0.2
	@ember-data/serializer/-private/transforms/string          | 371.00 B  | 70.83 B    | 1.6           | 0.2
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.15 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.05 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.04 KB' │
│  compressed  │ '3.44 KB'  │
│ % Of Library │   '8.9'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.88 KB   | 1.50 KB    | 43.7          | 3.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.92 KB   | 374.99 B   | 10.6          | 0.9
	@ember-data/adapter/error                                     | 1.82 KB   | 356.27 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.41 KB   | 276.08 B   | 7.8           | 0.7
	@ember-data/adapter/json-api                                  | 1.03 KB   | 202.19 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.62 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 769.00 B  | 146.82 B   | 4.2           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 556.00 B  | 106.15 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 488.00 B  | 93.17 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 450.00 B  | 85.91 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 382.00 B  | 72.93 B    | 2.1           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.38 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.06 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.64 KB' │
│  compressed  │ '1.65 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 387.97 B   | 23.0          | 1.0
	ember-data/-private/index                         | 1.49 KB   | 291.55 B   | 17.3          | 0.7
	ember-data/adapters/errors                        | 1.19 KB   | 232.36 B   | 13.8          | 0.6
	ember-data/-private/core                          | 368.00 B  | 70.26 B    | 4.2           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.26 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.71 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.31 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.92 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.77 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.39 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.39 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 46.01 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.25 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.29 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.15 B    | 2.6           | 0.1
	ember-data/model                                  | 222.00 B  | 42.38 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 42.38 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.62 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 30.73 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 579.28 B   | 44.4          | 1.5
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.64 B   | 23.8          | 0.8
	ember-inflector/lib/system                        | 471.00 B  | 89.92 B    | 6.9           | 0.2
	ember-inflector/index                             | 379.00 B  | 72.36 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 70.45 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 63.38 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.71 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.51 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '540.91 B' │
│ % Of Library │   '1.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 444.48 B   | 82.2          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.42 B    | 17.8          | 0.2

@runspired runspired merged commit 986cd87 into master Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired/port-6147 branch September 2, 2022 08:44
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Performance Report for 685e60c

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-52ms to 17ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-2ms to 3ms]
✅ Phase [start-data-generation] => [start-push-payload]
phase estimated improvement -3ms [-5ms to -1ms] OR -0.88% [-1.37% to -0.39%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-3ms to 15ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -21ms [-40ms to -6ms] OR -2.98% [-5.71% to -0.86%]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-13ms to 0ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 8ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-2ms to 3ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-1ms to 5ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-3ms to 3ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - relationship-materialization-complex: ☑️ Performance is stable

☑️ duration
phase no difference [-18ms to 29ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-4ms to 1ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-1ms to 1ms]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-6ms to 5ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-5ms to 2ms]
☑️ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase no difference [-9ms to 25ms]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-4ms to 6ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-16ms to 5ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 1ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-3ms to 4ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-4ms to 4ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-26ms to 4ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 3ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-12ms to 1ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-6ms to 2ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-5ms to 4ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-9ms to 9ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-2ms to 4ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-6ms to 2ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-2ms to 2ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-5ms to 6ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-4ms to 5ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-3ms to 1ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 7ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-3ms to 3ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-4ms to 3ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Commit v Release Performance Report for 685e60c

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -2177ms [-2277ms to -2080ms] OR -37.56% [-39.28% to -35.88%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-9ms to 11ms]
✅ Phase [start-data-generation] => [start-push-payload]
phase estimated improvement -9ms [-17ms to -2ms] OR -2.09% [-3.69% to -0.49%]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -1054ms [-1085ms to -1026ms] OR -36.06% [-37.13% to -35.11%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -135ms [-137ms to -132ms] OR -96.75% [-98.22% to -94.45%]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -628ms [-673ms to -504ms] OR -45.66% [-48.94% to -36.67%]
✅ Phase [end-record-materialization] => [Test End]
phase estimated improvement -217ms [-384ms to -193ms] OR -77.74% [-137.59% to -69.16%]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -525ms [-540ms to -505ms] OR -38.4% [-39.51% to -36.96%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-12ms to 5ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -99ms [-105ms to -92ms] OR -19.13% [-20.39% to -17.86%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -330ms [-334ms to -326ms] OR -75.77% [-76.77% to -74.76%]
✅ Phase [end-materialization] => [Test End]
phase estimated improvement -90ms [-93ms to -87ms] OR -68.52% [-70.54% to -66.27%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -1434ms [-1498ms to -1376ms] OR -20.05% [-20.95% to -19.25%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 11ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-4ms to 3ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -430ms [-443ms to -419ms] OR -30.85% [-31.83% to -30.06%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -64ms [-65ms to -63ms] OR -95.88% [-97.07% to -94.42%]
✅ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated improvement -291ms [-297ms to -283ms] OR -48.32% [-49.48% to -47.14%]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -441ms [-489ms to -396ms] OR -11.31% [-12.53% to -10.14%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -205ms [-214ms to -195ms] OR -30.61% [-32.03% to -29.18%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -373ms [-391ms to -355ms] OR -22.92% [-24.04% to -21.85%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 9ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -242ms [-251ms to -233ms] OR -28.79% [-29.86% to -27.73%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -132ms [-136ms to -128ms] OR -40.42% [-41.59% to -39.22%]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -18153ms [-18216ms to -18084ms] OR -87.12% [-87.43% to -86.79%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-9ms to 16ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -690ms [-709ms to -673ms] OR -36.35% [-37.38% to -35.45%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -487ms [-499ms to -476ms] OR -54.82% [-56.19% to -53.52%]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -16978ms [-17032ms to -16913ms] OR -97.45% [-97.76% to -97.08%]
✅ Phase [end-unload-all] => [Test End]
phase estimated improvement -2ms [-3ms to -1ms] OR -4.45% [-6.17% to -2.51%]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -527ms [-545ms to -510ms] OR -29.15% [-30.11% to -28.17%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 12ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -220ms [-229ms to -210ms] OR -26.79% [-27.97% to -25.63%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -311ms [-317ms to -305ms] OR -58.67% [-59.86% to -57.59%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -272ms [-290ms to -256ms] OR -24.1% [-25.68% to -22.66%]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-12ms to 10ms]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -109ms [-114ms to -105ms] OR -34.65% [-36.07% to -33.22%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -119ms [-123ms to -114ms] OR -43.54% [-45.18% to -41.91%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -46ms [-48ms to -44ms] OR -52.85% [-54.92% to -51%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -289ms [-307ms to -271ms] OR -21.51% [-22.85% to -20.17%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 12ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -250ms [-261ms to -241ms] OR -29.46% [-30.73% to -28.35%]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -36ms [-37ms to -34ms] OR -45.8% [-48.12% to -43.72%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ test This PR primarily adds tests for a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant