Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restructure graph home #8161

Merged
merged 1 commit into from
Sep 2, 2022
Merged

chore: restructure graph home #8161

merged 1 commit into from
Sep 2, 2022

Conversation

runspired
Copy link
Contributor

just a little file shuffling to get ready to cleanup the graph some more

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies labels Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Asset Size Report for ca894af

Modern Builds

☑️ EmberData has not changed in size

If any packages had changed sizes they would be listed here.

Changeset



Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '165.17 KB' │
│ compressed │ '35.30 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.75 KB' │
│  compressed  │ '9.56 KB'  │
│ % Of Library │   '27.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.27 KB  | 9.46 KB    | 98.9          | 26.8
	@ember-data/model/index                           | 486.00 B  | 103.86 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '42.96 KB' │
│  compressed  │ '9.18 KB'  │
│ % Of Library │   '26.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 41.96 KB  | 8.97 KB    | 97.7          | 25.4
	@ember-data/store/index                           | 1022.00 B | 218.42 B   | 2.3           | 0.6

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.36 KB' │
│  compressed  │ '4.99 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.36 KB  | 4.99 KB    | 100.0         | 14.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.42 KB' │
│  compressed  │ '4.36 KB'  │
│ % Of Library │   '12.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.57 KB    | 36.0          | 4.5
	@ember-data/serializer/-private                   | 5.60 KB   | 1.20 KB    | 27.4          | 3.4
	@ember-data/serializer/json-api                   | 3.79 KB   | 829.44 B   | 18.6          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 627.05 B   | 14.0          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 130.58 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.94 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.93 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '9.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.88 KB   | 1.68 KB    | 49.5          | 4.8
	@ember-data/adapter/-private                      | 3.79 KB   | 828.37 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 398.79 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 309.03 B   | 8.9           | 0.9
	@ember-data/adapter/json-api                      | 1.03 KB   | 226.32 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.32 KB' │
│  compressed  │ '1.78 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 434.27 B   | 23.8          | 1.2
	ember-data/-private                               | 1.53 KB   | 335.75 B   | 18.4          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 260.09 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.64 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.96 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.55 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 53.64 B    | 2.9           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.36 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.93 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 51.50 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.65 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.58 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.30 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 47.44 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.59 B    | 2.6           | 0.1
	ember-data/version                                | 161.00 B  | 34.40 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.42 KB' │
│ % Of Library │   '4.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 648.42 B   | 44.4          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 347.71 B   | 23.8          | 1.0
	ember-inflector/lib/system                        | 471.00 B  | 100.66 B   | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 80.99 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 78.86 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.95 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.96 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.26 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '605.46 B' │
│ % Of Library │   '1.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 497.53 B   | 82.2          | 1.4
	@ember-data/debug/setup                           | 505.00 B  | 107.92 B   | 17.8          | 0.3

Modern Builds (No Rollup)

🛑 The size of the library EmberData has increased by +287.0 B (+22.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/record-data has increased by +287.0 B.

Changeset


EmberData 204.41 KB +287.0 B (39.02 KB +22.0 B compressed)
    @ember-data/record-data 30.75 KB +287.0 B (5.87 KB +22.0 B compressed)
        @ember-data/record-data/-private/graph/index 482.0 B -5.61 KB (92.0 B -440.08 B compressed)
        @ember-data/record-data/-private/graph/graph 5.89 KB +5.89 KB (1.12 KB +462.08 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '204.41 KB' │
│ compressed │ '39.02 KB'  │
│  packages  │      8      │
│  modules   │     126     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '64.03 KB' │
│  compressed  │ '12.22 KB' │
│ % Of Library │   '31.3'   │
└──────────────┴────────────┘
	Module                                                                        | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/store-service                                      | 10.59 KB  | 2.02 KB    | 16.5          | 5.2
	@ember-data/store/-private/managers/record-data-manager                       | 7.90 KB   | 1.51 KB    | 12.3          | 3.9
	@ember-data/store/-private/caches/instance-cache                              | 5.90 KB   | 1.13 KB    | 9.2           | 2.9
	@ember-data/store/-private/network/fetch-manager                              | 4.89 KB   | 954.93 B   | 7.6           | 2.4
	@ember-data/store/-private/record-arrays/identifier-array                     | 4.27 KB   | 834.30 B   | 6.7           | 2.1
	@ember-data/store/-private/caches/identifier-cache                            | 3.66 KB   | 715.77 B   | 5.7           | 1.8
	@ember-data/store/-private/network/snapshot                                   | 3.31 KB   | 647.05 B   | 5.2           | 1.6
	@ember-data/store/-private/managers/record-array-manager                      | 3.07 KB   | 600.67 B   | 4.8           | 1.5
	@ember-data/store/-private/index                                              | 2.74 KB   | 534.63 B   | 4.3           | 1.3
	@ember-data/store/-private/proxies/promise-proxies                            | 1.68 KB   | 327.91 B   | 2.6           | 0.8
	@ember-data/store/-private/managers/record-data-store-wrapper                 | 1.62 KB   | 317.22 B   | 2.5           | 0.8
	@ember-data/store/-private/network/request-cache                              | 1.61 KB   | 313.79 B   | 2.5           | 0.8
	@ember-data/store/-private/legacy-model-support/shim-model-class              | 1.55 KB   | 302.15 B   | 2.4           | 0.8
	@ember-data/store/-private/network/finders                                    | 1.51 KB   | 295.85 B   | 2.4           | 0.7
	@ember-data/store/-private/legacy-model-support/schema-definition-service     | 1.37 KB   | 268.55 B   | 2.1           | 0.7
	@ember-data/store/-private/legacy-model-support/record-reference              | 1.34 KB   | 261.68 B   | 2.1           | 0.7
	@ember-data/store/index                                                       | 1022.00 B | 195.07 B   | 1.6           | 0.5
	@ember-data/store/-private/utils/uuid-polyfill                                | 786.00 B  | 150.02 B   | 1.2           | 0.4
	@ember-data/store/-private/managers/record-notification-manager               | 753.00 B  | 143.72 B   | 1.1           | 0.4
	@ember-data/store/-private/network/snapshot-record-array                      | 691.00 B  | 131.89 B   | 1.1           | 0.3
	@ember-data/store/-private/utils/construct-resource                           | 688.00 B  | 131.32 B   | 1.0           | 0.3
	@ember-data/store/-private/utils/common                                       | 572.00 B  | 109.17 B   | 0.9           | 0.3
	@ember-data/store/-private/utils/coerce-id                                    | 473.00 B  | 90.28 B    | 0.7           | 0.2
	@ember-data/store/-private/proxies/promise-proxy-base                         | 403.00 B  | 76.92 B    | 0.6           | 0.2
	@ember-data/store/-private/caches/record-data-for                             | 325.00 B  | 62.03 B    | 0.5           | 0.2
	@ember-data/store/-private/utils/identifer-debug-consts                       | 304.00 B  | 58.02 B    | 0.5           | 0.1
	@ember-data/store/-private/utils/promise-record                               | 291.00 B  | 55.54 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/serializer-response                          | 258.00 B  | 49.24 B    | 0.4           | 0.1
	@ember-data/store/-private/utils/normalize-model-name                         | 219.00 B  | 41.80 B    | 0.3           | 0.1
	@ember-data/store/-debug/index                                                | 207.00 B  | 39.51 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                          | 204.00 B  | 38.93 B    | 0.3           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '51.09 KB' │
│  compressed  │ '9.75 KB'  │
│ % Of Library │   '25.0'   │
└──────────────┴────────────┘
	Module                                                      | Bytes     | Compressed | % of Package  | % Of Library
	---------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                            | 11.25 KB  | 2.15 KB    | 22.0          | 5.5
	@ember-data/model/-private/legacy-relationships-support     | 7.94 KB   | 1.52 KB    | 15.5          | 3.9
	@ember-data/model/-private/record-state                     | 6.52 KB   | 1.25 KB    | 12.8          | 3.2
	@ember-data/model/-private/references/has-many              | 3.20 KB   | 625.67 B   | 6.3           | 1.6
	@ember-data/model/-private/references/belongs-to            | 2.81 KB   | 549.90 B   | 5.5           | 1.4
	@ember-data/model/-private/promise-many-array               | 2.70 KB   | 528.14 B   | 5.3           | 1.3
	@ember-data/model/-private/legacy-data-fetch                | 2.59 KB   | 505.42 B   | 5.1           | 1.3
	@ember-data/model/-private/many-array                       | 2.35 KB   | 458.85 B   | 4.6           | 1.1
	@ember-data/model/-private/errors                           | 2.31 KB   | 451.41 B   | 4.5           | 1.1
	@ember-data/model/-private/index                            | 1.48 KB   | 289.93 B   | 2.9           | 0.7
	@ember-data/model/-private/relationship-meta                | 991.00 B  | 189.15 B   | 1.9           | 0.5
	@ember-data/model/-private/notify-changes                   | 913.00 B  | 174.26 B   | 1.7           | 0.4
	@ember-data/model/-private/attr                             | 839.00 B  | 160.14 B   | 1.6           | 0.4
	@ember-data/model/-private/has-many                         | 817.00 B  | 155.94 B   | 1.6           | 0.4
	@ember-data/model/-private/belongs-to                       | 736.00 B  | 140.48 B   | 1.4           | 0.4
	@ember-data/model/-private/deprecated-promise-proxy         | 681.00 B  | 129.98 B   | 1.3           | 0.3
	@ember-data/model/-private/promise-belongs-to               | 615.00 B  | 117.38 B   | 1.2           | 0.3
	@ember-data/model/-private/util                             | 522.00 B  | 99.63 B    | 1.0           | 0.2
	@ember-data/model/index                                     | 486.00 B  | 92.76 B    | 0.9           | 0.2
	@ember-data/model/-private/diff-array                       | 445.00 B  | 84.93 B    | 0.9           | 0.2
	@ember-data/model/-private/model-for-mixin                  | 407.00 B  | 77.68 B    | 0.8           | 0.2
	@ember-data/model/-private/legacy-data-utils                | 395.00 B  | 75.39 B    | 0.8           | 0.2
	@ember-data/model/-private/promise-proxy-base               | 284.00 B  | 54.20 B    | 0.5           | 0.1

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '30.75 KB' │
│  compressed  │ '5.87 KB'  │
│ % Of Library │   '15.0'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 7.17 KB   | 1.37 KB    | 23.3          | 3.5
	@ember-data/record-data/-private/graph/graph                                      | 5.89 KB   | 1.12 KB    | 19.1          | 2.9
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.63 KB   | 710.23 B   | 11.8          | 1.8
	@ember-data/record-data/-private/graph/-edge-definition                           | 3.12 KB   | 609.07 B   | 10.1          | 1.5
	@ember-data/record-data/-private/graph/-utils                                     | 2.10 KB   | 411.32 B   | 6.8           | 1.0
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.27 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/operations/merge-identifier                | 1.26 KB   | 246.03 B   | 4.1           | 0.6
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.21 KB   | 236.49 B   | 3.9           | 0.6
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 829.00 B  | 158.23 B   | 2.6           | 0.4
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 708.00 B  | 135.13 B   | 2.2           | 0.3
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 707.00 B  | 134.94 B   | 2.2           | 0.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 692.00 B  | 132.08 B   | 2.2           | 0.3
	@ember-data/record-data/-private/index                                            | 497.00 B  | 94.86 B    | 1.6           | 0.2
	@ember-data/record-data/-private/graph/index                                      | 482.00 B  | 92.00 B    | 1.5           | 0.2
	@ember-data/record-data/-private/coerce-id                                        | 379.00 B  | 72.34 B    | 1.2           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.92 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.42 B    | 0.8           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.63 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.43 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.36 KB   | 1.40 KB    | 32.8          | 3.6
	@ember-data/serializer/-private/embedded-records-mixin     | 4.59 KB   | 897.86 B   | 20.5          | 2.2
	@ember-data/serializer/json-api                            | 3.79 KB   | 740.77 B   | 16.9          | 1.9
	@ember-data/serializer/rest                                | 2.87 KB   | 560.01 B   | 12.8          | 1.4
	@ember-data/serializer/-private/index                      | 1018.00 B | 194.30 B   | 4.4           | 0.5
	@ember-data/serializer/index                               | 611.00 B  | 116.62 B   | 2.7           | 0.3
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.16 B   | 2.3           | 0.3
	@ember-data/serializer/-private/transforms/boolean         | 504.00 B  | 96.19 B    | 2.2           | 0.2
	@ember-data/serializer/-private/transforms/number          | 439.00 B  | 83.79 B    | 1.9           | 0.2
	@ember-data/serializer/-private/transforms/string          | 371.00 B  | 70.81 B    | 1.6           | 0.2
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.13 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.03 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '18.04 KB' │
│  compressed  │ '3.44 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.88 KB   | 1.50 KB    | 43.7          | 3.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.92 KB   | 374.87 B   | 10.6          | 0.9
	@ember-data/adapter/error                                     | 1.82 KB   | 356.16 B   | 10.1          | 0.9
	@ember-data/adapter/index                                     | 1.41 KB   | 276.00 B   | 7.8           | 0.7
	@ember-data/adapter/json-api                                  | 1.03 KB   | 202.13 B   | 5.7           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.56 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 769.00 B  | 146.78 B   | 4.2           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 556.00 B  | 106.12 B   | 3.0           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 488.00 B  | 93.14 B    | 2.6           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 450.00 B  | 85.89 B    | 2.4           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 382.00 B  | 72.91 B    | 2.1           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.37 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.05 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.64 KB' │
│  compressed  │ '1.65 KB' │
│ % Of Library │   '4.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.98 KB   | 387.85 B   | 23.0          | 1.0
	ember-data/-private/index                         | 1.49 KB   | 291.46 B   | 17.3          | 0.7
	ember-data/adapters/errors                        | 1.19 KB   | 232.29 B   | 13.8          | 0.6
	ember-data/-private/core                          | 368.00 B  | 70.24 B    | 4.2           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.24 B    | 4.2           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.69 B    | 3.6           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.29 B    | 3.1           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.90 B    | 2.8           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.76 B    | 2.8           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.38 B    | 2.7           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.38 B    | 2.7           | 0.1
	ember-data/transform                              | 241.00 B  | 46.00 B    | 2.7           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.23 B    | 2.7           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.28 B    | 2.6           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.13 B    | 2.6           | 0.1
	ember-data/model                                  | 222.00 B  | 42.37 B    | 2.5           | 0.1
	ember-data/store                                  | 222.00 B  | 42.37 B    | 2.5           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.61 B    | 2.5           | 0.1
	ember-data/version                                | 161.00 B  | 30.73 B    | 1.8           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.67 KB' │
│  compressed  │ '1.27 KB' │
│ % Of Library │   '3.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.96 KB   | 579.10 B   | 44.4          | 1.4
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.54 B   | 23.8          | 0.8
	ember-inflector/lib/system                        | 471.00 B  | 89.90 B    | 6.9           | 0.2
	ember-inflector/index                             | 379.00 B  | 72.34 B    | 5.6           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 70.43 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 63.36 B    | 4.9           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.69 B    | 4.7           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.49 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.77 KB'  │
│  compressed  │ '540.74 B' │
│ % Of Library │   '1.4'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 444.34 B   | 82.2          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.39 B    | 17.8          | 0.2

@runspired runspired merged commit 21902b4 into master Sep 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the runspired/graph-cleanup branch September 2, 2022 09:32
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Performance Report for ca894af

Scenario - basic-record-materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-90ms to 28ms]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-7ms to 3ms]
✅ Phase [start-data-generation] => [start-push-payload]
phase estimated improvement -7ms [-13ms to -1ms] OR -1.3% [-2.48% to -0.25%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-26ms to 12ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [end-record-materialization]
phase no difference [-14ms to 34ms]
☑️ Phase [end-record-materialization] => [Test End]
phase no difference [-8ms to 1ms]

Scenario - relationship-materialization-simple: ☑️ Performance is stable

☑️ duration
phase no difference [-17ms to 13ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-4ms to 7ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-8ms to 4ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-7ms to 2ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-1ms to 2ms]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -55ms [-102ms to -11ms] OR -0.95% [-1.76% to -0.19%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-9ms to 5ms]
⚠️ Phase [start-data-generation] => [start-push-payload]
phase estimated regression +3ms [0ms to 6ms] OR +1.22% [0.13% to 2.28%]
☑️ Phase [start-push-payload] => [start-peek-records]
phase no difference [-8ms to 13ms]
☑️ Phase [start-peek-records] => [start-record-materialization]
phase no difference [0ms to 0ms]
☑️ Phase [start-record-materialization] => [start-relationship-materialization]
phase no difference [-2ms to 9ms]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -51ms [-83ms to -18ms] OR -1.47% [-2.4% to -0.51%]
☑️ Phase [end-relationship-materialization] => [Test End]
phase no difference [-15ms to 0ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 16ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 6ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-8ms to 4ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-2ms to 3ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unload-all: ☑️ Performance is stable

☑️ duration
phase no difference [-36ms to 31ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 9ms]
☑️ Phase [start-push-payload] => [start-materialization]
phase no difference [-21ms to 14ms]
☑️ Phase [start-materialization] => [start-unload-all]
phase no difference [-9ms to 6ms]
☑️ Phase [start-unload-all] => [end-unload-all]
phase no difference [-5ms to 12ms]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-11ms to 19ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-4ms to 11ms]
☑️ Phase [start-push-payload] => [start-destroy-records]
phase no difference [-8ms to 7ms]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 5ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-22ms to 4ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-17ms to 2ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-3ms to 3ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-4ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 0ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-16ms to 11ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-8ms to 4ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-5ms to 8ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [0ms to 0ms]

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Commit v Release Performance Report for ca894af

Scenario - basic-record-materialization: ✅ Performance improved

✅ duration
phase estimated improvement -1771ms [-1840ms to -1699ms] OR -35.22% [-36.6% to -33.8%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-7ms to 1ms]
✅ Phase [start-data-generation] => [start-push-payload]
phase estimated improvement -4ms [-8ms to -1ms] OR -1.03% [-1.83% to -0.19%]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -816ms [-835ms to -799ms] OR -32.88% [-33.63% to -32.17%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -133ms [-134ms to -131ms] OR -97.06% [-97.9% to -95.37%]
✅ Phase [start-record-materialization] => [end-record-materialization]
phase estimated improvement -527ms [-558ms to -334ms] OR -44.89% [-47.56% to -28.45%]
✅ Phase [end-record-materialization] => [Test End]
phase estimated improvement -193ms [-222ms to -178ms] OR -77.35% [-88.73% to -71.33%]

Scenario - relationship-materialization-simple: ✅ Performance improved

✅ duration
phase estimated improvement -455ms [-466ms to -444ms] OR -38.24% [-39.19% to -37.31%]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-4ms to 1ms]
✅ Phase [start-find-all] => [start-materialization]
phase estimated improvement -86ms [-90ms to -82ms] OR -18.86% [-19.76% to -17.93%]
✅ Phase [start-materialization] => [end-materialization]
phase estimated improvement -285ms [-288ms to -281ms] OR -79.14% [-80.06% to -78.22%]
✅ Phase [end-materialization] => [Test End]
phase estimated improvement -83ms [-85ms to -81ms] OR -71.23% [-72.74% to -69.89%]

Scenario - relationship-materialization-complex: ✅ Performance improved

✅ duration
phase estimated improvement -1207ms [-1251ms to -1166ms] OR -20.67% [-21.42% to -19.97%]
☑️ Phase [navigationStart] => [start-data-generation]
phase no difference [-5ms to 3ms]
☑️ Phase [start-data-generation] => [start-push-payload]
phase no difference [-2ms to 2ms]
✅ Phase [start-push-payload] => [start-peek-records]
phase estimated improvement -333ms [-341ms to -325ms] OR -29.41% [-30.15% to -28.66%]
✅ Phase [start-peek-records] => [start-record-materialization]
phase estimated improvement -61ms [-63ms to -60ms] OR -96.38% [-99.01% to -93.67%]
✅ Phase [start-record-materialization] => [start-relationship-materialization]
phase estimated improvement -242ms [-247ms to -237ms] OR -49.05% [-50.06% to -47.97%]
✅ Phase [start-relationship-materialization] => [end-relationship-materialization]
phase estimated improvement -388ms [-421ms to -354ms] OR -12.38% [-13.44% to -11.31%]
✅ Phase [end-relationship-materialization] => [Test End]
phase estimated improvement -186ms [-193ms to -178ms] OR -31.79% [-33.02% to -30.56%]

Scenario - unload: ✅ Performance improved

✅ duration
phase estimated improvement -308ms [-322ms to -293ms] OR -21.56% [-22.55% to -20.53%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-7ms to 4ms]
✅ Phase [start-push-payload] => [start-unload-records]
phase estimated improvement -184ms [-191ms to -178ms] OR -26.39% [-27.25% to -25.47%]
✅ Phase [start-unload-records] => [end-unload-records]
phase estimated improvement -121ms [-124ms to -118ms] OR -39.87% [-40.97% to -39.01%]
✅ Phase [end-unload-records] => [Test End]
phase estimated improvement -1ms [-1ms to 0ms] OR -1.96% [-2.42% to -1.47%]

Scenario - unload-all: ✅ Performance improved

✅ duration
phase estimated improvement -16246ms [-16408ms to -16147ms] OR -87.47% [-88.34% to -86.93%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-11ms to 4ms]
✅ Phase [start-push-payload] => [start-materialization]
phase estimated improvement -521ms [-539ms to -506ms] OR -33.5% [-34.7% to -32.56%]
✅ Phase [start-materialization] => [start-unload-all]
phase estimated improvement -432ms [-443ms to -424ms] OR -55.94% [-57.4% to -54.88%]
✅ Phase [start-unload-all] => [end-unload-all]
phase estimated improvement -15278ms [-15423ms to -15196ms] OR -97.67% [-98.6% to -97.14%]
☑️ Phase [end-unload-all] => [Test End]
phase no difference [-1ms to 0ms]

Scenario - destroy: ✅ Performance improved

✅ duration
phase estimated improvement -480ms [-493ms to -465ms] OR -29.66% [-30.45% to -28.76%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-6ms to 4ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -191ms [-198ms to -184ms] OR -26.22% [-27.17% to -25.28%]
✅ Phase [start-destroy-records] => [end-destroy-records]
phase estimated improvement -289ms [-293ms to -286ms] OR -61.77% [-62.47% to -61.03%]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ✅ Performance improved

✅ duration
phase estimated improvement -249ms [-258ms to -240ms] OR -24.13% [-25.04% to -23.33%]
✅ Phase [navigationStart] => [start-push-initial-payload]
phase estimated improvement -7ms [-12ms to -1ms] OR -1.56% [-2.77% to -0.26%]
✅ Phase [start-push-initial-payload] => [start-push-update-payload]
phase estimated improvement -96ms [-99ms to -93ms] OR -34.39% [-35.53% to -33.33%]
✅ Phase [start-push-update-payload] => [end-push-update-payload]
phase estimated improvement -102ms [-105ms to -100ms] OR -42.5% [-43.53% to -41.45%]
✅ Phase [end-push-update-payload] => [Test End]
phase estimated improvement -45ms [-45ms to -44ms] OR -57.91% [-58.78% to -57.08%]

Scenario - unused-relationships: ✅ Performance improved

✅ duration
phase estimated improvement -248ms [-258ms to -238ms] OR -20.66% [-21.5% to -19.86%]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-5ms to 3ms]
✅ Phase [start-push-payload] => [end-push-payload]
phase estimated improvement -211ms [-216ms to -206ms] OR -28.3% [-28.96% to -27.62%]
✅ Phase [end-push-payload] => [Test End]
phase estimated improvement -34ms [-35ms to -33ms] OR -50.34% [-51.77% to -48.9%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 canary PR is targeting canary (default) 🏷️ chore This PR primarily refactors code or updates dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant